Skip to content

Expose details of PoijiRowSpecificException #308

Closed
@virtual-machinist

Description

@virtual-machinist

Hi!

First of all, thank you for a wonderful library, the most feature-rich for parsing Excel spreadsheets I could find out there.

I have however a small feature request. When parsing the spreadsheet I must report all errors due to required missing data to an API. PoijiRowSpecificException does collect everything I want, but as a concatenated string. Parsing it back from the error message feels weird.

Can we expose the constructor parameters of PoijiRowSpecificException as properties in addition to the message?

Activity

github-actions

github-actions commented on Feb 29, 2024

@github-actions

Thank you for contributing to Poiji! Feel free to create a PR If you want to contribute directly :)

virtual-machinist

virtual-machinist commented on Mar 1, 2024

@virtual-machinist
ContributorAuthor

As a matter of fact, I could also use additional details in com.poiji.exception.HeaderMissingException, i.e.
missingExcelCellHeaders and missingExcelCellNameHeaders used to generate the message in AnnotationUtil:80.

@ozlerhakan, what do you think, is this something I can also add to the PR?

ozlerhakan

ozlerhakan commented on Mar 1, 2024

@ozlerhakan
Owner

Hey @virtual-machinist ,

Thank you for contributing Poiji! I highly appreciate!

Please go ahead!

virtual-machinist

virtual-machinist commented on Mar 1, 2024

@virtual-machinist
ContributorAuthor

@ozlerhakan, thanks, my pleasure.

I've updated the PR, both properties of HeaderMissingException are now exposed as well.

ozlerhakan

ozlerhakan commented on Mar 3, 2024

@ozlerhakan
Owner

Hi @virtual-machinist , after the release deployment, you can use your enhancement with 4.4.0 :), thank you!

virtual-machinist

virtual-machinist commented on Mar 3, 2024

@virtual-machinist
ContributorAuthor

Woah, that was fast. :) Thanks lots, @ozlerhakan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @virtual-machinist@ozlerhakan

      Issue actions

        Expose details of PoijiRowSpecificException · Issue #308 · ozlerhakan/poiji