Closed
Description
Hi!
First of all, thank you for a wonderful library, the most feature-rich for parsing Excel spreadsheets I could find out there.
I have however a small feature request. When parsing the spreadsheet I must report all errors due to required missing data to an API. PoijiRowSpecificException
does collect everything I want, but as a concatenated string. Parsing it back from the error message feels weird.
Can we expose the constructor parameters of PoijiRowSpecificException
as properties in addition to the message?
Activity
github-actions commentedon Feb 29, 2024
Thank you for contributing to Poiji! Feel free to create a PR If you want to contribute directly :)
virtual-machinist commentedon Mar 1, 2024
As a matter of fact, I could also use additional details in
com.poiji.exception.HeaderMissingException
, i.e.missingExcelCellHeaders
andmissingExcelCellNameHeaders
used to generate the message in AnnotationUtil:80.@ozlerhakan, what do you think, is this something I can also add to the PR?
ozlerhakan commentedon Mar 1, 2024
Hey @virtual-machinist ,
Thank you for contributing Poiji! I highly appreciate!
Please go ahead!
virtual-machinist commentedon Mar 1, 2024
@ozlerhakan, thanks, my pleasure.
I've updated the PR, both properties of
HeaderMissingException
are now exposed as well.ozlerhakan commentedon Mar 3, 2024
Hi @virtual-machinist , after the release deployment, you can use your enhancement with 4.4.0 :), thank you!
virtual-machinist commentedon Mar 3, 2024
Woah, that was fast. :) Thanks lots, @ozlerhakan !