Skip to content

Remove trailing spaces #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025
Merged

Remove trailing spaces #5185

merged 5 commits into from
Apr 14, 2025

Conversation

parkerbxyz
Copy link
Contributor

@parkerbxyz parkerbxyz commented Apr 14, 2025

Proposed Changes

  1. Removes trailing spaces in build.py
  2. Removes trailing spaces in descriptor files
  3. Regenerates files with bash build.sh

Similar to #1987. I'm proposing this change because my editor is configured to auto-delete trailing whitespace in files on save. This was causing a lot of files I worked on in #1934 to show unrelated whitespace changes. I found the source of these trailing spaces, removed them, and regenerated the files. This fixes the problem at its source and should prevent others from running into this in the future.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@nvuillam
Copy link
Member

We have a little issue with secretlint (not related to your PR), when it'll be fixed we'll be able to merge this PR :)

@nvuillam nvuillam merged commit 74fd812 into oxsecurity:main Apr 14, 2025
6 checks passed
@parkerbxyz parkerbxyz deleted the fix-whitespace branch April 14, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants