Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPStan install & Upgrade stale action #2469

Merged
merged 8 commits into from
Mar 25, 2023
Merged

Conversation

nvuillam
Copy link
Member

No description provided.

dependabot bot and others added 2 commits March 23, 2023 16:05
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v7...v8)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@nvuillam
Copy link
Member Author

nvuillam commented Mar 23, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.13s
✅ BASH shfmt 6 0 0 0.36s
✅ COPYPASTE jscpd yes no 2.83s
✅ DOCKERFILE hadolint 115 0 18.6s
✅ JSON eslint-plugin-jsonc 21 0 0 2.14s
✅ JSON jsonlint 19 0 0.19s
✅ JSON v8r 21 0 13.29s
⚠️ MARKDOWN markdownlint 311 0 230 6.62s
✅ MARKDOWN markdown-link-check 311 0 5.62s
✅ MARKDOWN markdown-table-formatter 311 0 0 19.56s
✅ OPENAPI spectral 1 0 1.37s
⚠️ PYTHON bandit 184 55 2.03s
✅ PYTHON black 184 0 0 4.86s
✅ PYTHON flake8 184 0 1.7s
✅ PYTHON isort 184 0 0 0.73s
✅ PYTHON mypy 184 0 6.84s
✅ PYTHON pylint 184 0 11.68s
⚠️ PYTHON pyright 184 250 16.19s
✅ REPOSITORY checkov yes no 30.12s
✅ REPOSITORY git_diff yes no 0.35s
✅ REPOSITORY secretlint yes no 13.83s
✅ REPOSITORY trivy yes no 28.99s
✅ SPELL cspell 749 0 21.81s
✅ SPELL misspell 569 0 0 0.94s
✅ XML xmllint 3 0 0 0.38s
✅ YAML prettier 81 0 0 2.84s
✅ YAML v8r 23 0 51.22s
✅ YAML yamllint 82 0 1.09s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Member Author

@llaville would you have an idea about how to solve this issue ?

https://github.com/oxsecurity/megalinter/actions/runs/4505019064/jobs/7930231095#step:7:329

It seems GPG key does not work anymore, or waits for something to push ENTER :/

@nvuillam nvuillam changed the title Upgrade stale action Fix PHPStan install & Upgrade stale action Mar 23, 2023
@nvuillam
Copy link
Member Author

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.13s
✅ BASH shfmt 6 0 0 0.03s
✅ COPYPASTE jscpd yes no 2.8s
✅ DOCKERFILE hadolint 115 0 13.72s
✅ JSON eslint-plugin-jsonc 21 0 0 1.82s
✅ JSON jsonlint 19 0 0.14s
✅ JSON npm-package-json-lint yes no 0.53s
✅ JSON v8r 21 0 12.23s
⚠️ MARKDOWN markdownlint 311 2 230 5.51s
⚠️ MARKDOWN markdown-link-check 311 28 261.84s
✅ MARKDOWN markdown-table-formatter 311 2 0 15.06s
✅ OPENAPI spectral 1 0 1.07s
⚠️ PYTHON bandit 184 55 2.05s
✅ PYTHON black 184 0 0 3.5s
✅ PYTHON flake8 184 0 1.33s
✅ PYTHON isort 184 0 0 0.43s
✅ PYTHON mypy 184 0 6.93s
✅ PYTHON pylint 184 0 10.04s
⚠️ PYTHON pyright 184 250 15.84s
✅ REPOSITORY checkov yes no 26.62s
⚠️ REPOSITORY devskim yes 61 1.02s
✅ REPOSITORY dustilock yes no 3.12s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 5.84s
✅ REPOSITORY syft yes no 0.72s
✅ REPOSITORY trivy yes no 16.49s
✅ SPELL cspell 749 0 17.79s
✅ SPELL misspell 569 2 0 0.45s
✅ XML xmllint 3 0 0 0.04s
✅ YAML prettier 81 0 0 2.59s
✅ YAML v8r 23 0 42.94s
✅ YAML yamllint 82 0 1.06s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit 5e57679 into main Mar 25, 2023
@nvuillam nvuillam deleted the dependencies/stale branch March 25, 2023 05:55
@ondrejmirtes
Copy link

I think you should be able to remove the whole Phive section from the PHPStan Dockerfile:

RUN --mount=type=secret,id=GITHUB_TOKEN GITHUB_AUTH_TOKEN="$(cat /run/secrets/GITHUB_TOKEN)" \
&& export GITHUB_AUTH_TOKEN \
&& wget --tries=5 -q -O phive.phar https://phar.io/releases/phive.phar \
&& wget --tries=5 -q -O phive.phar.asc https://phar.io/releases/phive.phar.asc \
&& PHAR_KEY_ID="0x9D8A98B29B2D5D79" \
&& ( gpg --keyserver keyserver.pgp.com --recv-keys "$PHAR_KEY_ID" \
|| gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$PHAR_KEY_ID" \
|| gpg --keyserver pgp.mit.edu --recv-keys "$PHAR_KEY_ID" \
|| gpg --keyserver hkps://keyserver.ubuntu.com --recv-keys "$PHAR_KEY_ID" ) \
&& gpg --verify phive.phar.asc phive.phar \
&& chmod +x phive.phar \
&& mv phive.phar /usr/local/bin/phive \
&& rm phive.phar.asc \

@nvuillam
Copy link
Member Author

Indeed it will reduce the size :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants