Skip to content

Conversation

@chengchingwen
Copy link
Contributor

@chengchingwen chengchingwen commented Oct 8, 2023

I'm basically mimicking the package fixes in JuliaLang/julia#48766. Not sure if there are any other issues.

Should fix #38 and probably also #39. It is also required for ztangent/ValSplit.jl#2.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (019aeb9) 95.45% compared to head (fb26718) 76.47%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #40       +/-   ##
===========================================
- Coverage   95.45%   76.47%   -18.99%     
===========================================
  Files           1        1               
  Lines          66       85       +19     
===========================================
+ Hits           63       65        +2     
- Misses          3       20       +17     
Files Coverage Δ
src/Tricks.jl 76.47% <48.57%> (-18.99%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.
It matches the changes we needed to make in Diffractor to keep it working after that change

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6444450877

  • 17 of 31 (54.84%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.8%) to 82.278%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Tricks.jl 17 31 54.84%
Totals Coverage Status
Change from base Build 4550146760: -15.8%
Covered Lines: 65
Relevant Lines: 79

💛 - Coveralls

@oxinabox oxinabox merged commit bc371ac into oxinabox:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

static_methods and static_method_count not constant folded in v1.10

4 participants