Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No default port 587 in the lib/sendmail_handler.ml #52

Open
F-Loyer opened this issue Feb 9, 2023 · 1 comment
Open

No default port 587 in the lib/sendmail_handler.ml #52

F-Loyer opened this issue Feb 9, 2023 · 1 comment

Comments

@F-Loyer
Copy link

F-Loyer commented Feb 9, 2023

In the sendmail_handler.ml, I guess we should read

let run_with_starttls
    ~hostname
    ?port
    ~domain
    ?authentication
    ~tls_authenticator
    ~from
    ~recipients
    ~mail
  =
  let port =
    match port with
    | Some port -> port
    | None -> 587
  in

Instead, we have None -> 465
@aronerben
Copy link
Contributor

@F-Loyer You're probably right. @mikonieminen @joseferben Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aronerben @F-Loyer