authz: silo endpoints #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
plotnick
approved these changes
Apr 19, 2022
| use crate::db::{ | ||
| self, | ||
| error::{public_error_from_diesel_pool, ErrorHandler, TransactionError}, | ||
| model::{ |
There was a problem hiding this comment.
Should we just use model::* here?
There was a problem hiding this comment.
In other files I like importing model and then using the models qualified with model::. However in this file there isn't much opportunity for confusion, so I also like model::*.
There was a problem hiding this comment.
I don't have much opinion. I'd be happy to use model:: here as well. But I'm not going to do it in this change -- it'd be a lot of extra delta.
davepacheco
added a commit
that referenced
this pull request
Apr 19, 2022
This reverts commit 1019643.
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds authz protection to the silo public API endpoints.