Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert all VPC lookups to new API, plus various by-id lookups #842

Merged
merged 63 commits into from
Mar 31, 2022
Merged

convert all VPC lookups to new API, plus various by-id lookups #842

merged 63 commits into from
Mar 31, 2022

Conversation

davepacheco
Copy link
Collaborator

@davepacheco davepacheco commented Mar 31, 2022 •
edited
Loading

See #798. This converts all lookups at the VPC level and below (that weren't covered by #839 and #840), plus a few lookup-by-ids that I found along the way.

@davepacheco
first cut
4610d1a
@davepacheco
rename Lookup
ef932a1
@davepacheco
formatting nit
9cc52b0
@davepacheco
formatting
5845149
@davepacheco
fix
49a10e3
@davepacheco
some notes, PoC diesel impl
491f30c
@davepacheco
get rid of Root
037b78f
@davepacheco
make LookupPath reachable through the whole path
ebaefb1
@davepacheco
some cleanup
ce4b362
@davepacheco
flesh out macros
aae2da4
@davepacheco
more macro cleanup
73f0f4b
@davepacheco
more cleanup
68b51cf
@davepacheco
more commonizing
6d265bb
@davepacheco
cleanup
e4a5844
@davepacheco
more commonizing
0e73f25
@davepacheco
lookup done enough to start trying it out
a414c1f
@davepacheco
prototype a few call sites in Nexus
c7941b3
@davepacheco
some basic tests are working by accident
5690db3
@davepacheco
cleanup
295182b
@davepacheco
fix up prototyping
bcf57a6
@davepacheco
replace one XXX with a comment
43d0102
@davepacheco
in-progress update to return entire path -- cannot work with macro_ru…
0a494ae 
…les!
@davepacheco
it works with macro_rules!
013e981
@davepacheco
half-finished effort at proc macro approah
785eda2
@davepacheco
more progress
a48722a
@davepacheco
more work
dd5ce40
@davepacheco
closer to compiling
1f1615c
@davepacheco
closer to compiling
4fede01
@davepacheco
nearly fixed
30ecdc8
@davepacheco
compiles!
9f557db
@davepacheco davepacheco changed the base branch from main to convert-new-lookup-routers March 31, 2022 21:26
david-crespo
david-crespo approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this really makes the case for the macro. it's great

Base automatically changed from convert-new-lookup-routers to main March 31, 2022 21:42
@davepacheco davepacheco marked this pull request as ready for review March 31, 2022 21:45
@davepacheco davepacheco enabled auto-merge (squash) March 31, 2022 21:45
@davepacheco davepacheco merged commit b409424 into main Mar 31, 2022
@davepacheco davepacheco deleted the convert-new-lookup-more branch March 31, 2022 22:23
@davepacheco davepacheco mentioned this pull request Mar 31, 2022
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-crespo david-crespo david-crespo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davepacheco @david-crespo