-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert route endpoints to new lookup API #839
Conversation
I think this is ready to review but it's blocked on #798. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Kind of funny that it's more code, but it's very nice code. And deleting vpc_router_lookup_by_path
eventually will offset it.
Yeah, I'd forgotten to remove |
never mind about it being more code! |
This is just sooo damn good. |
This change updates the "route" endpoints to use the new lookup API.
As part of this, I changed the
router_id
column on therouter_route
table to be calledvpc_router_id
, so that we can maintain the expectation that the foreign key id is derivable from the foreign table name. #798 depends on this.