Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authz: protect VPC Subnet endpoints #754

Merged
merged 11 commits into from
Mar 15, 2022
Merged

authz: protect VPC Subnet endpoints #754

merged 11 commits into from
Mar 15, 2022

Conversation

davepacheco
Copy link
Collaborator

@davepacheco davepacheco commented Mar 13, 2022

This is a work-in-progress but I'm hopeful that it's pretty close:

  • test oxapi_demo
  • update failing tests
  • verify that my update to the "unauthorized" test correctly fails prior to my changes

This was a little trickier than some of the other ones for a few reasons:

  • It's the first level of hierarchy below Projects that's not a leaf. I made a kind of cheesy generalization to authz::ProjectChild to make this work. I have some thoughts on making this more type-safe but I'd like to defer that for now because it'll affect many of the resources in that file.
  • There's a saga using some of these functions so I had to update it to use the saga facility for serializing creds

@bnaecker I didn't realize until I got pretty far into this that this will likely conflict with #713. I don't think the conflict will be too bad in either direction but it'll involve a bunch of manual fix-up. I'll take another look at #713 before trying to land this.

@davepacheco davepacheco mentioned this pull request Mar 13, 2022
71 tasks
@davepacheco davepacheco marked this pull request as ready for review March 15, 2022 00:08
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this!

@davepacheco davepacheco merged commit c4f49cf into main Mar 15, 2022
@davepacheco davepacheco deleted the authz-vpc branch March 15, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants