remove unneeded sled agent param

Author: gjcolombo

nexus/src/app/sagas/instance_migrate.rs

@@ -539,7 +539,6 @@ async fn sim_instance_migrate(
             InstanceStateChangeRequest::Migrate(
                 InstanceMigrationTargetParams {
                     src_propolis_addr: src_vmm_addr.to_string(),
-                    src_propolis_id,
                 },
             ),
         )

openapi/sled-agent.json

@@ -3828,16 +3828,10 @@
           "src_propolis_addr": {
             "description": "The address of the Propolis server that will serve as the migration source.",
             "type": "string"
-          },
-          "src_propolis_id": {
-            "description": "The Propolis ID of the migration source.",
-            "type": "string",
-            "format": "uuid"
           }
         },
         "required": [
-          "src_propolis_addr",
-          "src_propolis_id"
+          "src_propolis_addr"
         ]
       },
       "InstanceProperties": {

sled-agent/types/src/instance.rs

@@ -184,10 +184,6 @@ pub struct VmmUnregisterResponse {
 /// migration.
 #[derive(Copy, Clone, Debug, Deserialize, Serialize, JsonSchema)]
 pub struct InstanceMigrationTargetParams {
-    /// The Propolis ID of the migration source.
-    // TODO(gjc) try to get rid of this, migration targets don't use it anymore
-    pub src_propolis_id: Uuid,
-
     /// The address of the Propolis server that will serve as the migration
     /// source.
     pub src_propolis_addr: SocketAddr,