image: include /driver/cpu/amd/zen in cpio for dramtest #190
Conversation
| @@ -206,6 +210,7 @@ kernel/misc/amd64/sha2 | |||
| kernel/misc/amd64/skein | |||
| kernel/misc/amd64/strplumb | |||
| kernel/misc/amd64/tlimod | |||
| kernel/misc/amd64/zen_data | |||
There was a problem hiding this comment.
Do you need zen_data? As far as I know this just provides pin data for zen_gpio
There was a problem hiding this comment.
I have no idea! I just included everything that isn't a manual page haha. I will investigate though.
When we move to a minibar enabled world and have a NIC present (which I appreciate will not be for some time) can we then move to using a normal full boot image and not need to rely on this exceptionally private interface? At which point we will no longer need the subset of things here and would be able to remove the partial contents of this package? |
Sure! If someone wants to shove a PCIe NIC into the sharkfin slot on the board I suspect that would also work! The challenge has been that we do this prior to assembly in the chassis. If either of these are true, we can certainly stop doing this:
|
As part of building a new image for the DRAM testing station in manufacturing, I have rebased the dramtest branch of illumos on top of the latest stlouis bits. The code in the branch essentially blocks forever in the boot_image module, loads the zen_umc module, and prints out information about the DIMMs in the machine over and over. The manufacturing software knows how to interpret this data (by watching the console) to produce a report.
It would appear that the last time I built the image for this purpose, I was (somehow) including the zen_umc module and other parts of the /driver/cpu/amd/zen package in the cpio archive. It's possible that part of making the image ready for production involved trimming those files out.
The files are not strictly necessary in the regular image, but they also only increase the size of the compressed cpio archive from 8.22MB to 8.27MB. It doesn't seem worth adding complexity to make them optional here, given the small size.