Skip to content

Full page form spacing #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 3 commits into from
May 2, 2025
Merged

Full page form spacing #2815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86ad31a
Tighten full form divider spacing
benjaminleonard May 2, 2025
e5a117c
Hardware radio tweaks
benjaminleonard May 2, 2025
36204c8
switch to ! important
david-crespo May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"oxc"
],
"categories": {
"correctness": "error",
"correctness": "error"
},
"rules": {
// only worry about console.log
Expand Down
2 changes: 0 additions & 2 deletions app/forms/instance-create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,13 +905,11 @@ const PRESETS = [
{ category: 'general', id: 'general-sm', memory: 16, ncpus: 4 },
{ category: 'general', id: 'general-md', memory: 32, ncpus: 8 },
{ category: 'general', id: 'general-lg', memory: 64, ncpus: 16 },
{ category: 'general', id: 'general-xl', memory: 128, ncpus: 32 },

{ category: 'highCPU', id: 'highCPU-xs', memory: 4, ncpus: 2 },
{ category: 'highCPU', id: 'highCPU-sm', memory: 8, ncpus: 4 },
{ category: 'highCPU', id: 'highCPU-md', memory: 16, ncpus: 8 },
{ category: 'highCPU', id: 'highCPU-lg', memory: 32, ncpus: 16 },
{ category: 'highCPU', id: 'highCPU-xl', memory: 64, ncpus: 32 },

{ category: 'highMemory', id: 'highMemory-xs', memory: 16, ncpus: 2 },
{ category: 'highMemory', id: 'highMemory-sm', memory: 32, ncpus: 4 },
Expand Down
2 changes: 1 addition & 1 deletion app/ui/lib/Radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const Radio = ({ children, className, ...inputProps }: RadioProps) => (

const cardLabelStyles = `
py-2 px-4 text-sans-md border rounded border-default bg-default hover:border-hover
peer-focus:ring-2 peer-focus:ring-accent-secondary w-44
peer-focus:ring-2 peer-focus:ring-accent-secondary w-44 text-raise

children:py-3 children:px-3 children:-mx-4 children:border-secondary
first:children:-mt-2 last:children:-mb-2 cursor-pointer
Expand Down
10 changes: 3 additions & 7 deletions app/ui/styles/components/form.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
*
*
* Copyright Oxide Computer Company
*/

Expand All @@ -22,10 +22,6 @@
@apply space-y-6;
}

.ox-form.is-side-modal .ox-divider {
@apply my-10;
}

.ox-form:not(.is-side-modal) .ox-divider {
@apply mb-16 mt-20;
.ox-form .ox-divider {
@apply !my-10; /* important overrides space-y-* on .ox-form */
}
Loading