Simplify create button copy in modals #2785
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
(updating tests …) |
| loading={updatePolicy.isPending} | ||
| submitError={updatePolicy.error} | ||
| submitLabel="Assign role" | ||
| submitLabel="Assign" |
There was a problem hiding this comment.
I think all of those are harder to understand without the noun.
There was a problem hiding this comment.
It was my idea to shorten, lol. #2746 (comment). But that was in the context of a much longer one Attach floating IP, which I now see could be shortened to Attach IP. It was also in a PR about a non-side modal form. I think this shorter version might make more sense in the little modal forms because you can see everything right next to the button. With the side modal, I find the form a bit long and the title a bit far away to find a plain ADD intuitive.
There was a problem hiding this comment.
That makes sense! Will kill this PR and see about cleaning up just the button copy in free-floating modals.
This simplifies the copy on modal
createforms' action buttons, and restricts the types to a few select verbs.Open to approaching this another way, but this was a quick one to throw together, so I figured I'd put the PR up.
Closes #2749