fix e2e test

Author: david-crespo

mock-api/snapshot.ts

@@ -104,7 +104,7 @@ export const snapshots: Json<Snapshot>[] = [
 function generateSnapshot(index: number): Json<Snapshot> {
   return {
     id: uuid(),
-    name: `disk-1-snapshot-${index + 7}`,
+    name: `disk-1-snapshot-${index + 8}`,
     description: '',
     project_id: project.id,
     time_created: new Date().toISOString(),

test/e2e/pagination.e2e.ts

@@ -52,7 +52,7 @@ test('pagination', async ({ page }) => {
   await nextButton.click()
   await expectCell(page, 'disk-1-snapshot-76')
   await expectCell(page, 'disk-1-snapshot-86')
-  await expect(rows).toHaveCount(11)
+  await expect(rows).toHaveCount(12)
   await expect(nextButton).toBeDisabled() // no more pages
 
   await scrollTo(page, 250)

test/e2e/snapshots.e2e.ts

@@ -5,7 +5,7 @@
  *
  * Copyright Oxide Computer Company
  */
-import { expect, expectNotVisible, expectRowVisible, expectVisible, test } from './utils'
+import { expect, expectRowVisible, expectVisible, test } from './utils'
 
 test('Click through snapshots', async ({ page }) => {
   await page.goto('/projects/mock-project')
@@ -28,7 +28,7 @@ test('Click through snapshots', async ({ page }) => {
 test('Confirm delete snapshot', async ({ page }) => {
   await page.goto('/projects/mock-project/snapshots')
 
-  const row = page.getByRole('row', { name: 'disk-1-snapshot-7' })
+  const row = page.getByRole('row', { name: 'disk-1-snapshot-10' })
 
   // scroll a little so the dropdown menu isn't behind the pagination bar
   await page.getByRole('table').click() // focus the content pane
@@ -53,7 +53,8 @@ test('Confirm delete snapshot', async ({ page }) => {
   await page.getByRole('button', { name: 'Confirm' }).click()
 
   // modal closes, row is gone
-  await expectNotVisible(page, [modal, row])
+  await expect(modal).toBeHidden()
+  await expect(row).toBeHidden()
 })
 
 test('Error on delete snapshot', async ({ page }) => {