avoid unsetting optional fields in instance update

Author: david-crespo

app/pages/project/instances/AutoRestartCard.tsx

@@ -76,14 +76,16 @@ export function AutoRestartCard() {
       path: { instance: instanceSelector.instance },
       query: { project: instanceSelector.project },
       body: {
-        ncpus: instance.ncpus,
-        memory: instance.memory,
-        bootDisk: instance.bootDiskId,
         autoRestartPolicy: match(values.autoRestartPolicy)
           .with('default', () => undefined)
           .with('never', () => 'never' as const)
           .with('best_effort', () => 'best_effort' as const)
           .exhaustive(),
+        ncpus: instance.ncpus,
+        memory: instance.memory,
+        // optional ones would be unset if we left them out
+        cpuPlatform: instance.cpuPlatform,
+        bootDisk: instance.bootDiskId,
       },
     })
   })

app/pages/project/instances/InstancePage.tsx

@@ -341,7 +341,14 @@ export function ResizeInstanceModal({
     instanceUpdate.mutate({
       path: { instance: instance.name },
       query: { project },
-      body: { ncpus, memory: memory * GiB, bootDisk: instance.bootDiskId },
+      body: {
+        ncpus,
+        memory: memory * GiB,
+        // these need to be passed in or they'll be unset
+        bootDisk: instance.bootDiskId,
+        cpuPlatform: instance.cpuPlatform,
+        autoRestartPolicy: instance.autoRestartPolicy,
+      },
     })
   })
   const formId = useId()

app/pages/project/instances/StorageTab.tsx

@@ -167,8 +167,9 @@ export default function StorageTab() {
                   bootDisk: undefined,
                   ncpus: instance.ncpus,
                   memory: instance.memory,
-                  // this would get unset if we left it out
+                  // optional ones would be unset if we left them out
                   autoRestartPolicy: instance.autoRestartPolicy,
+                  cpuPlatform: instance.cpuPlatform,
                 },
               }),
             errorTitle: 'Could not unset boot disk',
@@ -205,6 +206,7 @@ export default function StorageTab() {
       instance.autoRestartPolicy,
       instance.ncpus,
       instance.memory,
+      instance.cpuPlatform,
       getSnapshotAction,
     ]
   )
@@ -231,8 +233,9 @@ export default function StorageTab() {
                   bootDisk: disk.id,
                   ncpus: instance.ncpus,
                   memory: instance.memory,
-                  // this would get unset if we left it out
+                  // optional ones would be unset if we left them out
                   autoRestartPolicy: instance.autoRestartPolicy,
+                  cpuPlatform: instance.cpuPlatform,
                 },
               }),
             errorTitle: `Could not ${verb} boot disk`,
@@ -283,6 +286,7 @@ export default function StorageTab() {
       instance.autoRestartPolicy,
       instance.ncpus,
       instance.memory,
+      instance.cpuPlatform,
       getSnapshotAction,
       bootDisks,
     ]