Skip to content

Add Milan 1.0.0.g config #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Milan 1.0.0.g config #242

wants to merge 7 commits into from

Conversation

daym
Copy link
Collaborator

@daym daym commented May 8, 2025

No description provided.

@daym daym marked this pull request as ready for review May 15, 2025 00:48
@daym daym requested a review from dancrossnyc May 15, 2025 00:48
dancrossnyc
dancrossnyc reviewed May 15, 2025
View reviewed changes
Copy link
Contributor

@dancrossnyc dancrossnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all the commits down. The change itself looks fine; the CI failure was (I believe) a transient network issue.

@daym
Copy link
Collaborator Author

daym commented May 15, 2025

Successfully tested on olivia.

@dancrossnyc
Copy link
Contributor

LG; just gotta squash the commits.

@dancrossnyc
Copy link
Contributor

(And we need to test on a gimlet; perhaps c71 off of Cadbury?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancrossnyc dancrossnyc dancrossnyc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daym @dancrossnyc