-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(transformer/arrow-functions): reduce repeated code #8323
Merged
graphite-app
merged 1 commit into
main
from
01-07-refactor_transformer_arrow-functions_reduce_repeated_code
Jan 8, 2025
Merged
refactor(transformer/arrow-functions): reduce repeated code #8323
graphite-app
merged 1 commit into
main
from
01-07-refactor_transformer_arrow-functions_reduce_repeated_code
Jan 8, 2025
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2025
github-actions
bot
added
A-transformer
Area - Transformer / Transpiler
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
labels
Jan 7, 2025
CodSpeed Performance ReportMerging #8323 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor
branch
from
January 7, 2025 14:46
d18c78c
to
1e65b59
Compare
overlookmotel
force-pushed
the
01-07-refactor_transformer_arrow-functions_reduce_repeated_code
branch
from
January 7, 2025 14:46
8135368
to
28469ba
Compare
Merge activity
|
Dunqing
force-pushed
the
01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor
branch
from
January 8, 2025 01:36
1e65b59
to
a718c25
Compare
Dunqing
pushed a commit
that referenced
this pull request
Jan 8, 2025
Follow-on after #8024. Pure refactor. Make `self.visit_statement(stmt)` only get called in one place, rather than 2.
Dunqing
force-pushed
the
01-07-refactor_transformer_arrow-functions_reduce_repeated_code
branch
from
January 8, 2025 01:36
28469ba
to
65ed432
Compare
Follow-on after #8024. Pure refactor. Make `self.visit_statement(stmt)` only get called in one place, rather than 2.
Dunqing
force-pushed
the
01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor
branch
from
January 8, 2025 01:54
a718c25
to
62e3f7e
Compare
Dunqing
force-pushed
the
01-07-refactor_transformer_arrow-functions_reduce_repeated_code
branch
from
January 8, 2025 01:55
65ed432
to
73d0025
Compare
Base automatically changed from
01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor
to
main
January 8, 2025 02:12
graphite-app
bot
deleted the
01-07-refactor_transformer_arrow-functions_reduce_repeated_code
branch
January 8, 2025 02:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-transformer
Area - Transformer / Transpiler
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #8024. Pure refactor. Make
self.visit_statement(stmt)
only get called in one place, rather than 2.