Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/arrow-functions): reduce repeated code #8323

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 7, 2025

Follow-on after #8024. Pure refactor. Make self.visit_statement(stmt) only get called in one place, rather than 2.

Copy link
Contributor Author

overlookmotel commented Jan 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 7, 2025
Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #8323 will not alter performance

Comparing 01-07-refactor_transformer_arrow-functions_reduce_repeated_code (73d0025) with 01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor (62e3f7e)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review January 7, 2025 14:32
@overlookmotel overlookmotel requested a review from Dunqing as a code owner January 7, 2025 14:32
@overlookmotel overlookmotel force-pushed the 01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor branch from d18c78c to 1e65b59 Compare January 7, 2025 14:46
@overlookmotel overlookmotel force-pushed the 01-07-refactor_transformer_arrow-functions_reduce_repeated_code branch from 8135368 to 28469ba Compare January 7, 2025 14:46
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2025
Copy link

graphite-app bot commented Jan 8, 2025

Merge activity

@Dunqing Dunqing force-pushed the 01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor branch from 1e65b59 to a718c25 Compare January 8, 2025 01:36
Dunqing pushed a commit that referenced this pull request Jan 8, 2025
Follow-on after #8024. Pure refactor. Make `self.visit_statement(stmt)` only get called in one place, rather than 2.
@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_reduce_repeated_code branch from 28469ba to 65ed432 Compare January 8, 2025 01:36
Follow-on after #8024. Pure refactor. Make `self.visit_statement(stmt)` only get called in one place, rather than 2.
@Dunqing Dunqing force-pushed the 01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor branch from a718c25 to 62e3f7e Compare January 8, 2025 01:54
@Dunqing Dunqing force-pushed the 01-07-refactor_transformer_arrow-functions_reduce_repeated_code branch from 65ed432 to 73d0025 Compare January 8, 2025 01:55
Base automatically changed from 01-07-perf_transformer_arrow-functions_reduce_size_of_inlined_visitor to main January 8, 2025 02:12
@graphite-app graphite-app bot merged commit 73d0025 into main Jan 8, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 01-07-refactor_transformer_arrow-functions_reduce_repeated_code branch January 8, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant