Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to tikv-jemallocator #583

Closed
wants to merge 1 commit into from

Conversation

cijiugechu
Copy link
Contributor

We are currently using jemallocator. We should switch to tikv-jemallocator.

See This PR for context.

TL;DR:

tikv-jemallocator is a fork of the jemallocator crate. As of December 2021, tikv-jemallocator uses a jemalloc version that is newer and has better performance than the jemalloc version used by jemallocator.

from this site.

@github-actions github-actions bot added A-minifier Area - Minifier A-resolver Area - Resolver labels Jul 22, 2023
@Boshen
Copy link
Member

Boshen commented Jul 22, 2023

That's outdated. See https://github.com/tikv/jemallocator#tikv-jemallocator

The project is published as tikv-jemallocator and jemallocator for historical reasons. The two crates are the same except names. It's OK to use either crate.

I chose the one without tikv for fewer key strokes.

The benchmark indicates there are no differences as well https://github.com/Boshen/oxc/actions/runs/5629597928?pr=583.

@Boshen
Copy link
Member

Boshen commented Jul 22, 2023

Let me raise an issue over there. nnethercote/perf-book#67

@cijiugechu cijiugechu closed this Jul 22, 2023
@Boshen Boshen removed A-minifier Area - Minifier A-resolver Area - Resolver labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants