Skip to content

fix(import/no-namespace): remove dot special case #15032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix(import/no-namespace): remove dot special case #15032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions crates/oxc_linter/src/rules/import/no_namespace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,19 +107,11 @@ impl Rule for NoNamespace {
ImportImportName::NamespaceObject => {
let source = entry.module_request.name();

if self.ignore.is_empty() {
ctx.diagnostic(no_namespace_diagnostic(entry.local_name.span));
} else {
if !source.contains('.') {
return;
}

if self.ignore.iter().any(|pattern| {
glob_match(pattern.as_str(), source.trim_start_matches("./"))
}) {
return;
}

if self.ignore.is_empty()
|| self.ignore.iter().all(|pattern| {
!glob_match(pattern.as_str(), source.trim_start_matches("./"))
})
{
ctx.diagnostic(no_namespace_diagnostic(entry.local_name.span));
}
}
Expand Down Expand Up @@ -152,6 +144,13 @@ fn test() {
(r"import * as foo from 'foo';", None),
(r"import defaultExport, * as foo from 'foo';", None),
(r"import * as foo from './foo';", None),
(
r"
import * as zod from 'zod'
import * as DrizzleKit from 'drizzle-kit/api'
",
Some(serde_json::json!([{ "ignore": ["zod"] }])),
),
];

Tester::new(NoNamespace::NAME, NoNamespace::PLUGIN, pass, fail)
Expand Down
9 changes: 9 additions & 0 deletions crates/oxc_linter/src/snapshots/import_no_namespace.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,12 @@ source: crates/oxc_linter/src/tester.rs
· ───
╰────
help: Use named or default imports

⚠ eslint-plugin-import(no-namespace): Usage of namespaced aka wildcard "*" imports prohibited
╭─[index.js:3:25]
2 │ import * as zod from 'zod'
3 │ import * as DrizzleKit from 'drizzle-kit/api'
· ──────────
4 │
╰────
help: Use named or default imports
Loading