Skip to content

fix(codegen): print legal comments above directives #14993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix(codegen): print legal comments above directives #14993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/oxc_codegen/src/gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ impl Gen for Hashbang<'_> {

impl Gen for Directive<'_> {
fn r#gen(&self, p: &mut Codegen, _ctx: Context) {
p.print_comments_at(self.span.start);
p.add_source_mapping(self.span);
p.print_indent();
// A Use Strict Directive may not contain an EscapeSequence or LineContinuation.
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_codegen/tests/integration/comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ pub mod legal {
* @preserve
*/
",
// Issue #14953: legal comments above directives
"/*!\n * legal comment\n */\n\n\"use strict\";\n\nexport const foo = 'foo';",
]
}

Expand Down
18 changes: 17 additions & 1 deletion crates/oxc_codegen/tests/integration/snapshots/legal_eof_comments.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
source: crates/oxc_codegen/tests/integration/main.rs
source: crates/oxc_codegen/tests/integration/tester.rs
---
########## 0
/* @license */
Expand Down Expand Up @@ -127,3 +127,19 @@ function foo() {
/**
* @preserve
*/

########## 9
/*!
* legal comment
*/

"use strict";

export const foo = 'foo';
----------
'use strict';
export const foo = 'foo';

/*!
* legal comment
*/
16 changes: 15 additions & 1 deletion crates/oxc_codegen/tests/integration/snapshots/legal_eof_minify_comments.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
source: crates/oxc_codegen/tests/integration/main.rs
source: crates/oxc_codegen/tests/integration/tester.rs
---
########## 0
/* @license */
Expand Down Expand Up @@ -109,3 +109,17 @@ function foo(){(()=>{
/**
* @preserve
*/

########## 9
/*!
* legal comment
*/

"use strict";

export const foo = 'foo';
----------
'use strict';export const foo=`foo`;
/*!
* legal comment
*/
17 changes: 16 additions & 1 deletion crates/oxc_codegen/tests/integration/snapshots/legal_inline_comments.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
source: crates/oxc_codegen/tests/integration/main.rs
source: crates/oxc_codegen/tests/integration/tester.rs
---
########## 0
/* @license */
Expand Down Expand Up @@ -112,3 +112,18 @@ function foo() {
/**
* @preserve
*/

########## 9
/*!
* legal comment
*/

"use strict";

export const foo = 'foo';
----------
/*!
* legal comment
*/
'use strict';
export const foo = 'foo';
15 changes: 14 additions & 1 deletion crates/oxc_codegen/tests/integration/snapshots/legal_linked_comments.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
source: crates/oxc_codegen/tests/integration/main.rs
source: crates/oxc_codegen/tests/integration/tester.rs
---
########## 0
/* @license */
Expand Down Expand Up @@ -108,3 +108,16 @@ function foo() {
*/

/*! For license information please see test.js */
########## 9
/*!
* legal comment
*/

"use strict";

export const foo = 'foo';
----------
'use strict';
export const foo = 'foo';

/*! For license information please see test.js */
Loading