Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 21, 2025

Requires this or super to run the no-this-before-super rule. Should be fairly robust as both of those node types are in the name of the rule, so I don't expect this to need much changing later.

-4 microseconds on the RadixUI benchmark.

Copy link
Member Author

camchenry commented Oct 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2025

CodSpeed Performance Report

Merging #14866 will not alter performance

Comparing 10-21-perf_linter_no-this-before-super_only_run_when_file_contains_super_or_this (18d736f) with main (a1cda35)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on 10-21-perf_linter_max-classes-per-file_skip_when_no_classes (cef7b00) during the generation of this report, so main (a1cda35) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 22, 2025
Copy link
Contributor

camc314 commented Oct 22, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from 10-21-perf_linter_max-classes-per-file_skip_when_no_classes to graphite-base/14866 October 22, 2025 08:14
@graphite-app graphite-app bot changed the base branch from graphite-base/14866 to main October 22, 2025 08:18
…er or this (#14866)

Requires `this` or `super` to run the `no-this-before-super` rule. Should be fairly robust as both of those node types are in the name of the rule, so I don't expect this to need much changing later.

-4 microseconds on the RadixUI benchmark.
@graphite-app graphite-app bot force-pushed the 10-21-perf_linter_no-this-before-super_only_run_when_file_contains_super_or_this branch from 18d736f to ef53462 Compare October 22, 2025 08:19
@graphite-app graphite-app bot merged commit ef53462 into main Oct 22, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 10-21-perf_linter_no-this-before-super_only_run_when_file_contains_super_or_this branch October 22, 2025 08:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 22, 2025
@camc314 camc314 self-assigned this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants