Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 17, 2025

Follow-on after #14637. Just a small stylistic thing - reorder a few lines.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 17, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 17, 2025 12:49
Copilot AI review requested due to automatic review settings October 17, 2025 12:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A minor code style improvement that reorders variable declarations within the #[estree(raw_deser = "...")] attribute in Program serialization code. The change moves the start and end constant declarations to appear after the comments-related code block, improving logical grouping of the code.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Oct 17, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
Copy link
Member Author

overlookmotel commented Oct 17, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 17, 2025

CodSpeed Performance Report

Merging #14725 will not alter performance

Comparing 10-17-style_linter_plugins_reorder_code (64de6ff) with main (58ba6d6)

Summary

✅ 37 untouched

Follow-on after #14637. Just a small stylistic thing - reorder a few lines.
@graphite-app graphite-app bot force-pushed the 10-17-style_linter_plugins_reorder_code branch from 64de6ff to 3029dfb Compare October 17, 2025 12:55
@graphite-app graphite-app bot merged commit 3029dfb into main Oct 17, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 10-17-style_linter_plugins_reorder_code branch October 17, 2025 13:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants