perf(linter): refactor no-unsafe-finally to have a diverging match as first statement

[camchenry]

Removes let statement blocking node type analysis. This does duplicate the node.kind() check, but this is negligible in effect.

[camchenry]

• perf(linter): update prefer-node-protocol to use diverging match #14699
• perf(linter): update catch-error-name to use top-level match #14698
• perf(linter): update no-extra-non-null-assertion to use diverging match #14697
• perf(linter): update typescript/array-type to only have top-level match #14696
• perf(linter): refactor jsdoc/require-yields to deref instead of self.0 #14695
• perf(linter): inline is_function_node calls for some jsdoc rules #14694
• perf(linter): refactor jest/require-hook to use top-level match #14693
• perf(linter): refactor jest/no-conditional-in-test to use diverging match #14692
• perf(linter): move root scope check into match arms in import/no-webpack-loader-syntax #14691
• perf(linter): refactor no-amd to do scope check after node type check #14690
• perf(linter): refactor no-unsafe-finally to have a diverging match as first statement #14689 👈 (View in Graphite)
• perf(linter): refactor no-labels to use top-level match on node kind #14688
• perf(linter): refactor class-methods-use-this to be analyzed #14687
• perf(linter): add codegen support for is_member_expression_kind in match #14677 : 1 other dependent PR (#14678 )
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #14689 will not alter performance

_{Comparing 10-16-perf_linter_refactor_no-unsafe-finally_to_have_a_diverging_match_as_first_statement (71cfeaa) with 10-16-perf_linter_refactor_no-labels_to_use_top-level_match_on_node_kind (801bb10)}

Summary

✅ 4 untouched
⏩ 33 skipped¹

Footnotes

1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Oct 17, 10:21 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Oct 17, 10:36 AM UTC: Merged by the Graphite merge queue.