Skip to content

refactor(linter/plugins, napi/parser): remove extraneous code from raw transfer deserializers #14683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

refactor(linter/plugins, napi/parser): remove extraneous code from raw transfer deserializers #14683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
377 changes: 0 additions & 377 deletions apps/oxlint/src-js/generated/deserialize.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions napi/parser/generated/deserialize/js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ export function deserialize(buffer, sourceText, sourceByteLen) {
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}

export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {
uint8 = buffer;
uint32 = buffer.uint32;
Expand Down
4 changes: 0 additions & 4 deletions napi/parser/generated/deserialize/js_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ export function deserialize(buffer, sourceText, sourceByteLen) {
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}

export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {
uint8 = buffer;
uint32 = buffer.uint32;
Expand Down
4 changes: 0 additions & 4 deletions napi/parser/generated/deserialize/js_range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ export function deserialize(buffer, sourceText, sourceByteLen) {
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}

export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {
uint8 = buffer;
uint32 = buffer.uint32;
Expand Down
4 changes: 0 additions & 4 deletions napi/parser/generated/deserialize/js_range_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ export function deserialize(buffer, sourceText, sourceByteLen) {
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}

export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {
uint8 = buffer;
uint32 = buffer.uint32;
Expand Down
4 changes: 0 additions & 4 deletions napi/parser/generated/deserialize/ts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ export function deserialize(buffer, sourceText, sourceByteLen) {
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}

export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {
uint8 = buffer;
uint32 = buffer.uint32;
Expand Down
4 changes: 0 additions & 4 deletions napi/parser/generated/deserialize/ts_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ export function deserialize(buffer, sourceText, sourceByteLen) {
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}

export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {
uint8 = buffer;
uint32 = buffer.uint32;
Expand Down
4 changes: 0 additions & 4 deletions napi/parser/generated/deserialize/ts_range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ export function deserialize(buffer, sourceText, sourceByteLen) {
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}

export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {
uint8 = buffer;
uint32 = buffer.uint32;
Expand Down
4 changes: 0 additions & 4 deletions napi/parser/generated/deserialize/ts_range_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ export function deserialize(buffer, sourceText, sourceByteLen) {
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}

export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {
uint8 = buffer;
uint32 = buffer.uint32;
Expand Down
16 changes: 11 additions & 5 deletions tasks/ast_tools/src/generators/raw_transfer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,13 +152,17 @@ fn generate_deserializers(
}}
}});

/* IF !LINTER */
export function deserialize(buffer, sourceText, sourceByteLen) {{
return deserializeWith(buffer, sourceText, sourceByteLen, null, deserializeRawTransferData);
}}
/* END_IF */

/* IF LINTER */
export function deserializeProgramOnly(buffer, sourceText, sourceByteLen, getLoc) {{
return deserializeWith(buffer, sourceText, sourceByteLen, getLoc, deserializeProgram);
}}
/* END_IF */

function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInput, deserialize) {{
uint8 = buffer;
Expand Down Expand Up @@ -216,11 +220,11 @@ fn generate_deserializers(
variant_paths: Vec<String>,
}

impl VariantGenerator<6> for VariantGen {
const FLAG_NAMES: [&str; 6] =
["IS_TS", "RANGE", "LOC", "PARENT", "PRESERVE_PARENS", "COMMENTS"];
impl VariantGenerator<7> for VariantGen {
const FLAG_NAMES: [&str; 7] =
["IS_TS", "RANGE", "LOC", "PARENT", "PRESERVE_PARENS", "COMMENTS", "LINTER"];

fn variants(&mut self) -> Vec<[bool; 6]> {
fn variants(&mut self) -> Vec<[bool; 7]> {
let mut variants = Vec::with_capacity(9);

// Parser deserializers
Expand All @@ -237,6 +241,7 @@ fn generate_deserializers(
variants.push([
is_ts, range, /* loc */ false, parent,
/* preserve_parens */ true, /* comments */ false,
/* linter */ false,
]);
}
}
Expand All @@ -247,6 +252,7 @@ fn generate_deserializers(
variants.push([
/* is_ts */ true, /* range */ true, /* loc */ true,
/* parent */ true, /* preserve_parens */ false, /* comments */ true,
/* linter */ true,
]);

variants
Expand All @@ -255,7 +261,7 @@ fn generate_deserializers(
fn pre_process_variant<'a>(
&self,
program: &mut Program<'a>,
flags: [bool; 6],
flags: [bool; 7],
allocator: &'a Allocator,
) {
if flags[2] {
Expand Down
Loading