Skip to content

feat(semantic): add scope to TSCallSignatureDeclaration #14672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

feat(semantic): add scope to TSCallSignatureDeclaration #14672

merged 1 commit into from
Oct 16, 2025

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 16, 2025 •
edited
Loading

This is required else:

interface X {
    (a): void
    (a): void
}

will result in a semantic error or a​ being declared twice

@github-actions github-actions bot added A-ast Area - AST C-enhancement Category - New feature or request labels Oct 16, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 16, 2025
Merged
Merged
@camc314 camc314 marked this pull request as ready for review October 16, 2025 15:49
Copilot AI review requested due to automatic review settings October 16, 2025 15:49
Copilot AI reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds scope tracking capability to TypeScript call signature declarations by introducing the #[scope] attribute and a scope_id field. This enables proper semantic analysis and scope resolution for call signature declarations in the TypeScript AST.

  • Added #[scope] attribute to TSCallSignatureDeclaration struct
  • Added scope_id field to store the scope identifier for the call signature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@camc314 camc314 requested a review from Dunqing October 16, 2025 15:49
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14672 will not alter performance

Comparing c/10-16-feat_semantic_add_scope_to_tscallsignaturedeclaration_ (f45d2f0) with main (d161729)

Summary

✅ 37 untouched

@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_scope_to_tscallsignaturedeclaration_ branch from c125ad6 to 783a9f8 Compare October 16, 2025 15:55
@github-actions github-actions bot added the A-semantic Area - Semantic label Oct 16, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 16, 2025
@camc314 camc314 force-pushed the c/10-16-feat_semantic_add_scope_to_tscallsignaturedeclaration_ branch from 783a9f8 to 1662dc8 Compare October 16, 2025 16:04
@camc314 camc314 removed the 0-merge Merge with Graphite Merge Queue label Oct 16, 2025
@camc314
feat(semantic): add scope to TSCallSignatureDeclaration (#14672)
f45d2f0 
This is required else:

```
interface X {
    (a): void
    (a): void
}
```

will result in a semantic error or `a`​ being declared twice
@graphite-app graphite-app bot force-pushed the c/10-16-feat_semantic_add_scope_to_tscallsignaturedeclaration_ branch from 1662dc8 to f45d2f0 Compare October 16, 2025 16:09
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 16, 2025 •
edited by graphite-app bot
Loading

Merge activity

@camc314 camc314 mentioned this pull request Oct 16, 2025
Merged
@graphite-app graphite-app bot merged commit f45d2f0 into main Oct 16, 2025
29 checks passed
@graphite-app graphite-app bot deleted the c/10-16-feat_semantic_add_scope_to_tscallsignaturedeclaration_ branch October 16, 2025 16:15
@Boshen Boshen mentioned this pull request Oct 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Dunqing Dunqing Dunqing approved these changes

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

@Dunqing Dunqing

Labels

A-ast Area - AST A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camc314 @Dunqing