Skip to content

test(oxlint): add test for nested configs importing the same plugin 2x #14646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

test(oxlint): add test for nested configs importing the same plugin 2x #14646

merged 1 commit into from
Oct 20, 2025

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 15, 2025 •
edited
Loading

@overlookmotel looks like we already handle this case here:

oxc/crates/oxc_linter/src/config/config_builder.rs

Lines 535 to 537 in 55becc5

if external_plugin_store.is_plugin_registered(&plugin_path) {
return Ok(());
}

@camc314 camc314 mentioned this pull request Oct 15, 2025
Merged
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Oct 15, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 15, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review October 15, 2025 22:20
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 20, 2025
@camc314 camc314 assigned camc314 and unassigned overlookmotel Oct 20, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 20, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/10-13-add_repro branch from 55becc5 to 28e76ec Compare October 20, 2025 10:03
@graphite-app graphite-app bot force-pushed the c/10-15-test_oxlint_add_test_for_nested_configs_importing_the_same_plugin_2x branch from 205e18d to 5933097 Compare October 20, 2025 10:04
Base automatically changed from c/10-13-add_repro to main October 20, 2025 10:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 20, 2025
@graphite-app graphite-app bot merged commit 5933097 into main Oct 20, 2025
19 checks passed
@graphite-app graphite-app bot deleted the c/10-15-test_oxlint_add_test_for_nested_configs_importing_the_same_plugin_2x branch October 20, 2025 10:09
@Boshen Boshen mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camc314 @overlookmotel