Skip to content

refactor(linter/no-new-require): improve diagnostic message clarity #14511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
Merged

refactor(linter/no-new-require): improve diagnostic message clarity #14511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions crates/oxc_linter/src/rules/node/no_new_require.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ use oxc_span::Span;
use crate::{AstNode, context::LintContext, rule::Rule};

fn no_new_require(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Unexpected use of new with require")
OxcDiagnostic::warn("Unexpected use of `new` operator with `require`")
.with_help("Separate `require()` from `new` operator")
.with_label(span)
.with_help("Initialise the constructor separate from the import statement")
}

#[derive(Debug, Default, Clone)]
Expand Down Expand Up @@ -46,12 +46,9 @@ impl Rule for NoNewRequire {
let AstKind::NewExpression(new_expression) = node.kind() else {
return;
};

if !new_expression.callee.is_specific_id("require") {
return;
if new_expression.callee.is_specific_id("require") {
ctx.diagnostic(no_new_require(new_expression.span));
}

ctx.diagnostic(no_new_require(new_expression.span));
}
}

Expand Down
8 changes: 4 additions & 4 deletions crates/oxc_linter/src/snapshots/node_no_new_require.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
---
source: crates/oxc_linter/src/tester.rs
---
⚠ eslint-plugin-node(no-new-require): Unexpected use of new with require
⚠ eslint-plugin-node(no-new-require): Unexpected use of `new` operator with `require`
╭─[no_new_require.tsx:1:17]
1 │ var appHeader = new require('app-header')
· ─────────────────────────
╰────
help: Initialise the constructor separate from the import statement
help: Separate `require()` from `new` operator

⚠ eslint-plugin-node(no-new-require): Unexpected use of new with require
⚠ eslint-plugin-node(no-new-require): Unexpected use of `new` operator with `require`
╭─[no_new_require.tsx:1:17]
1 │ var appHeader = new require('headers').appHeader
· ──────────────────────
╰────
help: Initialise the constructor separate from the import statement
help: Separate `require()` from `new` operator
Loading