Skip to content

fix(linter): correct nextjs/no-typos path handling #14480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

fix(linter): correct nextjs/no-typos path handling #14480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions crates/oxc_linter/src/rules/nextjs/no_typos.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,17 @@ const THRESHOLD: usize = 1;

impl Rule for NoTypos {
fn should_run(&self, ctx: &ContextHost) -> bool {
let Some(path) = ctx.file_path().to_str() else {
return false;
};
let Some(path_after_pages) = path.split("pages").nth(1) else {
return false;
};
if path_after_pages.starts_with("/api") {
return false;
let path = ctx.file_path();
let mut found_pages = false;
for component in path.components() {
if found_pages {
return component.as_os_str() != "api";
}
if component.as_os_str() == "pages" {
found_pages = true;
}
}
true
false
}

fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
Expand Down Expand Up @@ -222,17 +223,17 @@ fn test() {
),
// even though there is a typo match, this should not fail because a file is inside pages/api directory
(
r"
export default function Page() {
return <div></div>;
}
export const getStaticpaths = async () => {};
export const getStaticProps = async () => {};
",
r"export const getStaticpaths = async () => {};",
None,
None,
Some(PathBuf::from("pages/api/test.tsx")),
),
(
r"export const getStaticpaths = async () => {};",
None,
None,
Some(PathBuf::from("pages\\api\\test.tsx")),
),
];

let fail = vec![
Expand Down
Loading