-
-
Notifications
You must be signed in to change notification settings - Fork 721
feat(codegen): allow attaching comment to the top of the file. #13048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codegen): allow attaching comment to the top of the file. #13048
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to allow attaching comments to the top of a file in the code generator. The changes enable comments to be positioned at the beginning of generated files rather than only inline with code elements.
Key changes:
- Added comment printing capability at the file start (position 0)
- Created test coverage for the new top-of-file comment functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_codegen/src/gen.rs | Added call to print comments at position 0 before other content |
| crates/oxc_codegen/tests/integration/comments.rs | Added test case to verify comments can be attached to file top |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #13048 will not alter performanceComparing Summary
Footnotes |
Merge activity
|
a9667d6 to
b1a6ba0
Compare

closes #12982