refactor(minifier): use the original vec in-place in minimize_statements
#13028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-minifier
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
CodSpeed Instrumentation Performance ReportMerging #13028 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
…ents` (#13028) Use the original vec in-place instead of re-building the statements vec. Re-buiding the vec will append data to the end of the memory arena, which is not cache friendly.
graphite-app
bot
force-pushed
the
08-12-refactor_minifier_separate_.minify_and_.dce_methods
branch
from
78fa81e to
993db89
Compare
graphite-app
bot
force-pushed
the
08-12-refactor_minifier_use_the_original_vec_as_the_buffer_in_minimize_statements_
branch
from
0d71de6 to
7223686
Compare
Base automatically changed from
08-12-refactor_minifier_separate_.minify_and_.dce_methods
to
main
August 12, 2025 15:05
graphite-app
bot
deleted the
08-12-refactor_minifier_use_the_original_vec_as_the_buffer_in_minimize_statements_
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…ents` (oxc-project#13028) Use the original vec in-place instead of re-building the statements vec. Re-buiding the vec will append data to the end of the memory arena, which is not cache friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the original vec in-place instead of re-building the statements vec.
Re-buiding the vec will append data to the end of the memory arena,
which is not cache friendly.