Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 12, 2025

#12953 altered the return type of GlobalContext::is_global_reference. Update docs accordingly.

@Boshen is this correct? Or does false now mean "not a global reference or unknown if is a global reference"?

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Aug 12, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review August 12, 2025 12:56
Copilot AI review requested due to automatic review settings August 12, 2025 12:56
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 12, 2025

CodSpeed Instrumentation Performance Report

Merging #13022 will not alter performance

Comparing 08-12-docs_ecmascript_correct_docs_for_globalcontext_is_global_reference_ (235607e) with main (6fe0bb5)

Summary

✅ 34 untouched benchmarks

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Boshen Boshen merged commit 9c05e2f into main Aug 12, 2025
31 checks passed
@Boshen Boshen deleted the 08-12-docs_ecmascript_correct_docs_for_globalcontext_is_global_reference_ branch August 12, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants