refactor(minifier): change AST in-place instead of returning Option<Expression>

[Boshen]

No description provided.

[Boshen]

• refactor(minifier): change AST in-place instead of returning Option<Expression> #12969 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR refactors the constant folding optimization in the minifier to modify the AST in-place instead of returning Option<Expression>. This eliminates the need for pattern matching on returned values and directly updates expressions when optimizations are possible.

Key changes:

• Functions now take &mut Expression and modify it directly instead of returning Option<Expression>
• Removed the outer pattern matching logic that checked for Some(folded_expr) and replaced expressions
• All fold functions now handle their own expression type checking and state updates

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12969 will not alter performance

_{Comparing 08-10-refactor_minifier_change_ast_in-place_instead_of_returning_option_expression_ (451bc07) with main (166f5cc)¹}

Summary

✅ 34 untouched benchmarks

Footnotes

1. No successful run was found on main (451bc07) during the generation of this report, so 166f5cc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[graphite-app]

Merge activity

• Aug 10, 5:03 PM UTC: Boshen added this pull request to the Graphite merge queue.
• Aug 10, 5:09 PM UTC: Merged by the Graphite merge queue.