Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 9, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 9, 2025 16:05
@github-actions github-actions bot added the A-minifier Area - Minifier label Aug 9, 2025
@Boshen Boshen added 0-merge Merge with Graphite Merge Queue and removed A-minifier Area - Minifier labels Aug 9, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Aug 9, 2025
Copy link
Member Author

Boshen commented Aug 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the JavaScript minifier to evaluate String constructor calls with constant arguments at compile time. The improvement transforms String(value) calls into string literals when the argument can be statically evaluated and has no side effects.

  • Replaces manual literal checking with constant evaluation for String() calls
  • Adds side effect checking to ensure safe transformations
  • Extends test coverage for boolean and expression arguments

Copy link
Member Author

Boshen commented Aug 9, 2025

Merge activity

  • Aug 9, 4:06 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 9, 4:18 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 9, 2025

CodSpeed Instrumentation Performance Report

Merging #12943 will not alter performance

Comparing 08-10-feat_minifier_evaluate_string_constructor (2453530) with main (d7e1ddb)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen merged commit 6e393ec into main Aug 9, 2025
30 checks passed
@Boshen Boshen deleted the 08-10-feat_minifier_evaluate_string_constructor branch August 9, 2025 16:16
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants