feat(minifier): f(!a === !1) -> f(!!a)
#12942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-minifier
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the minifier's condition minimization by optimizing boolean comparisons. Specifically, it transforms expressions like f(!a === !1) into f(!!a) and similar patterns.
- Refactors the
try_minimize_binaryfunction to handle boolean literal comparisons more efficiently - Simplifies the logic by early returns and improved value evaluation
- Adds comprehensive tests for the new optimization patterns
CodSpeed Instrumentation Performance ReportMerging #12942 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
08-09-feat_minifier_f_a_1_-_f_a_
branch
from
3eae493 to
ba1052d
Compare
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.