refactor(data_structures)!: remove PointerExt trait
#12903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12903 will not alter performanceComparing Summary
|
graphite-app
bot
changed the base branch from
08-08-chore_deps_raise_msrv_to_1.87.0
to
graphite-base/12903
graphite-app
bot
force-pushed
the
graphite-base/12903
branch
from
2d7df35 to
6d94216
Compare
graphite-app
bot
force-pushed
the
08-08-refactor_data_structures_remove_pointerext_trait
branch
from
d862c8c to
93da928
Compare
graphite-app
bot
force-pushed
the
08-08-refactor_data_structures_remove_pointerext_trait
branch
from
93da928 to
4360e72
Compare
Member
Merge activity
|
`PointerExt` trait was introduced to allow using `NonNull::offset_from_unsigned` (and similar APIs) on Rust v1.87.0 and above, without breaking code on earlier Rust versions where these APIs did not exist. Our MSRV is now v1.87.0 (#12900), so we can just use these methods directly, and `PointerExt` is not required any more. Remove it.
graphite-app
bot
force-pushed
the
08-08-refactor_data_structures_remove_pointerext_trait
branch
from
4360e72 to
128b527
Compare
graphite-app
bot
deleted the
08-08-refactor_data_structures_remove_pointerext_trait
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
) `PointerExt` trait was introduced to allow using `NonNull::offset_from_unsigned` (and similar APIs) on Rust v1.87.0 and above, without breaking code on earlier Rust versions where these APIs did not exist. Our MSRV is now v1.87.0 (oxc-project#12900), so we can just use these methods directly, and `PointerExt` is not required any more. Remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointerExttrait was introduced to allow usingNonNull::offset_from_unsigned(and similar APIs) on Rust v1.87.0 and above, without breaking code on earlier Rust versions where these APIs did not exist.Our MSRV is now v1.87.0 (#12900), so we can just use these methods directly, and
PointerExtis not required any more. Remove it.