Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 8, 2025

The explicit returns here are not required. Found by clippy in #12873.

@github-actions github-actions bot added A-cfg Area - Control Flow Graph C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 8, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 08-08-refactor_cfg_remove_unnecessary_return_statement branch from 49ec921 to 76d86e9 Compare August 8, 2025 08:53
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 8, 2025

CodSpeed Instrumentation Performance Report

Merging #12896 will not alter performance

Comparing 08-08-refactor_cfg_remove_unnecessary_return_statement (1cb8e1b) with main (c072e01)

Summary

✅ 34 untouched benchmarks

@github-actions github-actions bot added the A-formatter Area - Formatter label Aug 8, 2025
@overlookmotel overlookmotel changed the title refactor(cfg): remove unnecessary return statement refactor(cfg, formatter): remove unnecessary return statements Aug 8, 2025
@overlookmotel overlookmotel marked this pull request as ready for review August 8, 2025 08:54
@overlookmotel overlookmotel requested a review from Dunqing as a code owner August 8, 2025 08:54
@overlookmotel overlookmotel requested a review from camc314 August 8, 2025 08:54
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 8, 2025
Copy link
Contributor

camc314 commented Aug 8, 2025

Merge activity

)

The explicit `return`s here are not required. Found by clippy in #12873.
@graphite-app graphite-app bot force-pushed the 08-08-refactor_cfg_remove_unnecessary_return_statement branch from 76d86e9 to 1cb8e1b Compare August 8, 2025 09:00
@graphite-app graphite-app bot merged commit 1cb8e1b into main Aug 8, 2025
30 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 8, 2025
@graphite-app graphite-app bot deleted the 08-08-refactor_cfg_remove_unnecessary_return_statement branch August 8, 2025 09:06
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
…-project#12896)

The explicit `return`s here are not required. Found by clippy in oxc-project#12873.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cfg Area - Control Flow Graph A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants