test(transformer): rename babel-plugin-proposal-explicit-resource-management test directory
#12894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Copilot
AI
changed the title
[WIP] @oxc-project/oxc/pull/12874 There is a reasonable request change after this PR has been merged. Please create another follow-on PR to solve it.
fix: rename babel-plugin-proposal-explicit-resource-management test directory
Aug 8, 2025
Copilot finished work on behalf of
Dunqing
August 8, 2025 07:18
Dunqing
changed the title
babel-plugin-proposal-explicit-resource-management test directory
github-actions
bot
added
A-transformer
Dunqing
approved these changes
Aug 9, 2025
Member
Merge activity
|
Boshen
force-pushed
the
copilot/fix-7ac091b9-503e-4e3e-b3c9-1a37d86412c1
branch
from
dba2208 to
410f4ac
Compare
…nagement` test directory (#12894) Fixes missing test cases for explicit resource management by renaming the test directory to match the updated plugin name. ## Background PR #12874 updated references from the deprecated `@babel/plugin-proposal-explicit-resource-management` to the newer `@babel/plugin-transform-explicit-resource-management` package. However, the test directory under `tasks/transform_conformance/tests/` was not renamed, causing the test runner to miss 4 test cases. ## Issue The transform conformance test runner iterates through plugins defined in `constants.rs` and looks for test fixtures in directories matching the plugin names. Since the plugin name was updated to `babel-plugin-transform-explicit-resource-management` but the directory remained `babel-plugin-proposal-explicit-resource-management`, the test runner couldn't find the test cases. This resulted in 4 missing test cases in the `oxc.snap` file as noted by @Dunqing. ## Solution Renamed the test directory: ``` tasks/transform_conformance/tests/babel-plugin-proposal-explicit-resource-management/ → tasks/transform_conformance/tests/babel-plugin-transform-explicit-resource-management/ ``` ## Verification After the fix, running the transform conformance tests now correctly discovers and executes all 4 test cases: - export-class-name - for-of-no-block - function-with-scopes-in-params - try-catch The `oxc.snap` file now shows `babel-plugin-transform-explicit-resource-management (2/4)` indicating all 4 test cases are found (2 pass, 2 have implementation issues unrelated to this fix). Closes the follow-up issue identified in #12874. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/oxc-project/oxc/issues/new?title=✨Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
graphite-app
bot
force-pushed
the
copilot/fix-7ac091b9-503e-4e3e-b3c9-1a37d86412c1
branch
from
410f4ac to
ddc0b01
Compare
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…nagement` test directory (oxc-project#12894)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing test cases for explicit resource management by renaming the test directory to match the updated plugin name.
Background
PR #12874 updated references from the deprecated
@babel/plugin-proposal-explicit-resource-managementto the newer@babel/plugin-transform-explicit-resource-managementpackage. However, the test directory undertasks/transform_conformance/tests/was not renamed, causing the test runner to miss 4 test cases.Issue
The transform conformance test runner iterates through plugins defined in
constants.rsand looks for test fixtures in directories matching the plugin names. Since the plugin name was updated tobabel-plugin-transform-explicit-resource-managementbut the directory remainedbabel-plugin-proposal-explicit-resource-management, the test runner couldn't find the test cases.This resulted in 4 missing test cases in the
oxc.snapfile as noted by @Dunqing.Solution
Renamed the test directory:
Verification
After the fix, running the transform conformance tests now correctly discovers and executes all 4 test cases:
The
oxc.snapfile now showsbabel-plugin-transform-explicit-resource-management (2/4)indicating all 4 test cases are found (2 pass, 2 have implementation issues unrelated to this fix).Closes the follow-up issue identified in #12874.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.