refactor(transformer): Use to @babel/plugin-transform-explicit-resource-management
#12874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Copilot
AI
changed the title
[WIP] Change deprecated
Update deprecated @babel/plugin-proposal-explicit-resource-management to @babel/plugin-transform-explicit-resource-management
Aug 7, 2025
@babel/plugin-proposal-explicit-resource-management to @babel/plugin-transform-explicit-resource-management
Copilot finished work on behalf of
Boshen
August 7, 2025 12:37
CodSpeed Instrumentation Performance ReportMerging #12874 will not alter performanceComparing Summary
|
… to @babel/plugin-transform-explicit-resource-management Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Boshen
force-pushed
the
copilot/fix-27559304-0245-4dd3-a6f4-60d2893e84d2
branch
from
9b1e980 to
8738e3c
Compare
Boshen
changed the title
Boshen
changed the title
@babel/plugin-transform-explicit-resource-management
github-actions
bot
added
the
C-cleanup
Dunqing
reviewed
Aug 8, 2025
Member
There was a problem hiding this comment.
Should rename babel-plugin-proposal-explicit-resource-management to babel-plugin-transform-explicit-resource-management. This is the reason why oxc.snap misses 4 test cases
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 9, 2025
…nagement` test directory (#12894) Fixes missing test cases for explicit resource management by renaming the test directory to match the updated plugin name. ## Background PR #12874 updated references from the deprecated `@babel/plugin-proposal-explicit-resource-management` to the newer `@babel/plugin-transform-explicit-resource-management` package. However, the test directory under `tasks/transform_conformance/tests/` was not renamed, causing the test runner to miss 4 test cases. ## Issue The transform conformance test runner iterates through plugins defined in `constants.rs` and looks for test fixtures in directories matching the plugin names. Since the plugin name was updated to `babel-plugin-transform-explicit-resource-management` but the directory remained `babel-plugin-proposal-explicit-resource-management`, the test runner couldn't find the test cases. This resulted in 4 missing test cases in the `oxc.snap` file as noted by @Dunqing. ## Solution Renamed the test directory: ``` tasks/transform_conformance/tests/babel-plugin-proposal-explicit-resource-management/ → tasks/transform_conformance/tests/babel-plugin-transform-explicit-resource-management/ ``` ## Verification After the fix, running the transform conformance tests now correctly discovers and executes all 4 test cases: - export-class-name - for-of-no-block - function-with-scopes-in-params - try-catch The `oxc.snap` file now shows `babel-plugin-transform-explicit-resource-management (2/4)` indicating all 4 test cases are found (2 pass, 2 have implementation issues unrelated to this fix). Closes the follow-up issue identified in #12874. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/oxc-project/oxc/issues/new?title=✨Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates references from the deprecated
@babel/plugin-proposal-explicit-resource-managementto the newer@babel/plugin-transform-explicit-resource-managementpackage.Background
The
@babel/plugin-proposal-explicit-resource-managementpackage has been deprecated in favor of@babel/plugin-transform-explicit-resource-managementas the explicit resource management proposal has moved from experimental to stable status in the JavaScript specification.Changes Made
tasks/transform_conformance/src/constants.rsfrombabel-plugin-proposal-explicit-resource-managementtobabel-plugin-transform-explicit-resource-managementtasks/transform_conformance/package.jsonto use the new@babel/plugin-transform-explicit-resource-managementpackagecrates/oxc_transformer/src/proposals/explicit_resource_management.rsto reference the correct Babel plugin documentation URLsImpact
This change ensures that oxc stays current with the Babel ecosystem and avoids using deprecated packages.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.