Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: Add CI checks to vscode editor and client #7451

Closed
Tracked by #131
DonIsaac opened this issue Oct 16, 2024 · 0 comments · Fixed by #7427
Closed
Tracked by #131

editor: Add CI checks to vscode editor and client #7451

DonIsaac opened this issue Oct 16, 2024 · 0 comments · Fixed by #7427
Labels
A-editor Area - Editor and Language Server

Comments

@DonIsaac
Copy link
Contributor

DonIsaac commented Oct 16, 2024 •
edited
Loading

Add CI job to run oxlint and typescript type checking on VSCode client

Acceptance Criteria

  • do not re-build oxlint. use npx.
  • only type check with tsc (e.g. run tsc --noEmit)
  • job should have PR and push triggers
  • job should only trigger when a file in editor/vscode changes.
@DonIsaac DonIsaac mentioned this issue Oct 16, 2024
Closed
4 tasks
@DonIsaac DonIsaac added the A-editor Area - Editor and Language Server label Oct 16, 2024
@Sysix Sysix mentioned this issue Nov 22, 2024
Merged
Boshen referenced this issue Nov 23, 2024
@Sysix
ci(editor): add type-check (#7427)
9522d52 
probably closes https://github.com/oxc-project/backlog/issues/135
@overlookmotel overlookmotel transferred this issue from oxc-project/backlog Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-editor Area - Editor and Language Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(editor): add type-check Sysix/oxc
1 participant
@DonIsaac