refactor(linter): remove unused allocator param in Runtime for LSP & tests

Author: Sysix

crates/oxc_language_server/src/linter/isolated_lint_handler.rs

@@ -111,7 +111,6 @@ impl IsolatedLintHandler {
 
     fn lint_path(&mut self, path: &Path, uri: &Uri, source_text: &str) -> Vec<DiagnosticReport> {
         debug!("lint {}", path.display());
-        let mut allocator = Allocator::default();
         let rope = &Rope::from_str(source_text);
 
         let mut messages: Vec<DiagnosticReport> = self
@@ -121,7 +120,7 @@ impl IsolatedLintHandler {
                 Arc::from(source_text),
             )))
             .with_paths(vec![Arc::from(path.as_os_str())])
-            .run_source(&mut allocator)
+            .run_source()
             .iter()
             .map(|message| message_to_lsp_diagnostic(message, uri, source_text, rope))
             .collect();

crates/oxc_linter/src/service/mod.rs

@@ -96,18 +96,17 @@ impl LintService {
     }
 
     #[cfg(feature = "language_server")]
-    pub fn run_source(&mut self, allocator: &mut oxc_allocator::Allocator) -> Vec<crate::Message> {
-        self.runtime.run_source(allocator)
+    pub fn run_source(&mut self) -> Vec<crate::Message> {
+        self.runtime.run_source()
     }
 
     /// For tests
     #[cfg(test)]
     pub(crate) fn run_test_source(
         &mut self,
-        allocator: &mut oxc_allocator::Allocator,
         check_syntax_errors: bool,
         tx_error: &DiagnosticSender,
     ) -> Vec<crate::Message> {
-        self.runtime.run_test_source(allocator, check_syntax_errors, tx_error)
+        self.runtime.run_test_source(check_syntax_errors, tx_error)
     }
 }

crates/oxc_linter/src/service/runtime.rs

@@ -637,7 +637,7 @@ impl Runtime {
     // the struct not using `oxc_diagnostic::Error, because we are just collecting information
     // and returning it to the client to let him display it.
     #[cfg(feature = "language_server")]
-    pub(super) fn run_source(&mut self, _allocator: &mut oxc_allocator::Allocator) -> Vec<Message> {
+    pub(super) fn run_source(&mut self) -> Vec<Message> {
         use std::sync::Mutex;
 
         let messages = Mutex::new(Vec::<Message>::new());
@@ -706,7 +706,6 @@ impl Runtime {
     #[cfg(test)]
     pub(super) fn run_test_source(
         &mut self,
-        _allocator: &mut Allocator,
         check_syntax_errors: bool,
         tx_error: &DiagnosticSender,
     ) -> Vec<Message> {

crates/oxc_linter/src/tester.rs

@@ -501,7 +501,6 @@ impl Tester {
         fix_kind: ExpectFixKind,
         fix_index: u8,
     ) -> TestResult {
-        let mut allocator = Allocator::default();
         let rule = self.find_rule().read_json(rule_config.unwrap_or_default());
         let mut external_plugin_store = ExternalPluginStore::default();
         let linter = Linter::new(
@@ -552,7 +551,7 @@ impl Tester {
             .with_paths(paths);
 
         let (sender, _receiver) = mpsc::channel();
-        let result = lint_service.run_test_source(&mut allocator, false, &sender);
+        let result = lint_service.run_test_source(false, &sender);
 
         if result.is_empty() {
             return TestResult::Passed;