feat(ast): Add AstKind to AccessorProperty node (#11764)

This PR is part of the ongoing work in #11490

Adds AstKind to AccessorProperty nodes by removing the entry from the
list of exceptions in ast_tools.

Author: therewillbecode

crates/oxc_ast/src/ast_kind_impl.rs

@@ -204,6 +204,8 @@ impl AstKind<'_> {
             Self::MetaProperty(_) => "MetaProperty".into(),
             Self::Super(_) => "Super".into(),
 
+            Self::AccessorProperty(_) => "AccessorProperty".into(),
+
             Self::ArrayExpression(_) => "ArrayExpression".into(),
             Self::ArrowFunctionExpression(_) => "ArrowFunctionExpression".into(),
             Self::AssignmentExpression(_) => "AssignmentExpression".into(),

crates/oxc_ast/src/generated/ast_kind.rs

@@ -92,106 +92,107 @@ pub enum AstType {
     PrivateIdentifier = 76,
     StaticBlock = 77,
     ModuleDeclaration = 78,
-    ImportExpression = 79,
-    ImportDeclaration = 80,
-    ImportSpecifier = 81,
-    ImportDefaultSpecifier = 82,
-    ImportNamespaceSpecifier = 83,
-    WithClause = 84,
-    ExportNamedDeclaration = 85,
-    ExportDefaultDeclaration = 86,
-    ExportAllDeclaration = 87,
-    ExportSpecifier = 88,
-    V8IntrinsicExpression = 89,
-    BooleanLiteral = 90,
-    NullLiteral = 91,
-    NumericLiteral = 92,
-    StringLiteral = 93,
-    BigIntLiteral = 94,
-    RegExpLiteral = 95,
-    JSXElement = 96,
-    JSXOpeningElement = 97,
-    JSXClosingElement = 98,
-    JSXFragment = 99,
-    JSXOpeningFragment = 100,
-    JSXClosingFragment = 101,
-    JSXNamespacedName = 102,
-    JSXMemberExpression = 103,
-    JSXExpressionContainer = 104,
-    JSXEmptyExpression = 105,
-    JSXAttribute = 106,
-    JSXSpreadAttribute = 107,
-    JSXIdentifier = 108,
-    JSXSpreadChild = 109,
-    JSXText = 110,
-    TSThisParameter = 111,
-    TSEnumDeclaration = 112,
-    TSEnumBody = 113,
-    TSEnumMember = 114,
-    TSTypeAnnotation = 115,
-    TSLiteralType = 116,
-    TSConditionalType = 117,
-    TSUnionType = 118,
-    TSIntersectionType = 119,
-    TSParenthesizedType = 120,
-    TSTypeOperator = 121,
-    TSArrayType = 122,
-    TSIndexedAccessType = 123,
-    TSTupleType = 124,
-    TSNamedTupleMember = 125,
-    TSOptionalType = 126,
-    TSRestType = 127,
-    TSAnyKeyword = 128,
-    TSStringKeyword = 129,
-    TSBooleanKeyword = 130,
-    TSNumberKeyword = 131,
-    TSNeverKeyword = 132,
-    TSIntrinsicKeyword = 133,
-    TSUnknownKeyword = 134,
-    TSNullKeyword = 135,
-    TSUndefinedKeyword = 136,
-    TSVoidKeyword = 137,
-    TSSymbolKeyword = 138,
-    TSThisType = 139,
-    TSObjectKeyword = 140,
-    TSBigIntKeyword = 141,
-    TSTypeReference = 142,
-    TSTypeName = 143,
-    TSQualifiedName = 144,
-    TSTypeParameterInstantiation = 145,
-    TSTypeParameter = 146,
-    TSTypeParameterDeclaration = 147,
-    TSTypeAliasDeclaration = 148,
-    TSClassImplements = 149,
-    TSInterfaceDeclaration = 150,
-    TSPropertySignature = 151,
-    TSCallSignatureDeclaration = 152,
-    TSMethodSignature = 153,
-    TSConstructSignatureDeclaration = 154,
-    TSIndexSignatureName = 155,
-    TSInterfaceHeritage = 156,
-    TSTypePredicate = 157,
-    TSModuleDeclaration = 158,
-    TSModuleBlock = 159,
-    TSTypeLiteral = 160,
-    TSInferType = 161,
-    TSTypeQuery = 162,
-    TSImportType = 163,
-    TSMappedType = 164,
-    TSTemplateLiteralType = 165,
-    TSAsExpression = 166,
-    TSSatisfiesExpression = 167,
-    TSTypeAssertion = 168,
-    TSImportEqualsDeclaration = 169,
-    TSExternalModuleReference = 170,
-    TSNonNullExpression = 171,
-    Decorator = 172,
-    TSExportAssignment = 173,
-    TSNamespaceExportDeclaration = 174,
-    TSInstantiationExpression = 175,
-    JSDocNullableType = 176,
-    JSDocNonNullableType = 177,
-    JSDocUnknownType = 178,
+    AccessorProperty = 79,
+    ImportExpression = 80,
+    ImportDeclaration = 81,
+    ImportSpecifier = 82,
+    ImportDefaultSpecifier = 83,
+    ImportNamespaceSpecifier = 84,
+    WithClause = 85,
+    ExportNamedDeclaration = 86,
+    ExportDefaultDeclaration = 87,
+    ExportAllDeclaration = 88,
+    ExportSpecifier = 89,
+    V8IntrinsicExpression = 90,
+    BooleanLiteral = 91,
+    NullLiteral = 92,
+    NumericLiteral = 93,
+    StringLiteral = 94,
+    BigIntLiteral = 95,
+    RegExpLiteral = 96,
+    JSXElement = 97,
+    JSXOpeningElement = 98,
+    JSXClosingElement = 99,
+    JSXFragment = 100,
+    JSXOpeningFragment = 101,
+    JSXClosingFragment = 102,
+    JSXNamespacedName = 103,
+    JSXMemberExpression = 104,
+    JSXExpressionContainer = 105,
+    JSXEmptyExpression = 106,
+    JSXAttribute = 107,
+    JSXSpreadAttribute = 108,
+    JSXIdentifier = 109,
+    JSXSpreadChild = 110,
+    JSXText = 111,
+    TSThisParameter = 112,
+    TSEnumDeclaration = 113,
+    TSEnumBody = 114,
+    TSEnumMember = 115,
+    TSTypeAnnotation = 116,
+    TSLiteralType = 117,
+    TSConditionalType = 118,
+    TSUnionType = 119,
+    TSIntersectionType = 120,
+    TSParenthesizedType = 121,
+    TSTypeOperator = 122,
+    TSArrayType = 123,
+    TSIndexedAccessType = 124,
+    TSTupleType = 125,
+    TSNamedTupleMember = 126,
+    TSOptionalType = 127,
+    TSRestType = 128,
+    TSAnyKeyword = 129,
+    TSStringKeyword = 130,
+    TSBooleanKeyword = 131,
+    TSNumberKeyword = 132,
+    TSNeverKeyword = 133,
+    TSIntrinsicKeyword = 134,
+    TSUnknownKeyword = 135,
+    TSNullKeyword = 136,
+    TSUndefinedKeyword = 137,
+    TSVoidKeyword = 138,
+    TSSymbolKeyword = 139,
+    TSThisType = 140,
+    TSObjectKeyword = 141,
+    TSBigIntKeyword = 142,
+    TSTypeReference = 143,
+    TSTypeName = 144,
+    TSQualifiedName = 145,
+    TSTypeParameterInstantiation = 146,
+    TSTypeParameter = 147,
+    TSTypeParameterDeclaration = 148,
+    TSTypeAliasDeclaration = 149,
+    TSClassImplements = 150,
+    TSInterfaceDeclaration = 151,
+    TSPropertySignature = 152,
+    TSCallSignatureDeclaration = 153,
+    TSMethodSignature = 154,
+    TSConstructSignatureDeclaration = 155,
+    TSIndexSignatureName = 156,
+    TSInterfaceHeritage = 157,
+    TSTypePredicate = 158,
+    TSModuleDeclaration = 159,
+    TSModuleBlock = 160,
+    TSTypeLiteral = 161,
+    TSInferType = 162,
+    TSTypeQuery = 163,
+    TSImportType = 164,
+    TSMappedType = 165,
+    TSTemplateLiteralType = 166,
+    TSAsExpression = 167,
+    TSSatisfiesExpression = 168,
+    TSTypeAssertion = 169,
+    TSImportEqualsDeclaration = 170,
+    TSExternalModuleReference = 171,
+    TSNonNullExpression = 172,
+    Decorator = 173,
+    TSExportAssignment = 174,
+    TSNamespaceExportDeclaration = 175,
+    TSInstantiationExpression = 176,
+    JSDocNullableType = 177,
+    JSDocNonNullableType = 178,
+    JSDocUnknownType = 179,
 }
 
 /// Untyped AST Node Kind
@@ -282,6 +283,7 @@ pub enum AstKind<'a> {
     PrivateIdentifier(&'a PrivateIdentifier<'a>) = AstType::PrivateIdentifier as u8,
     StaticBlock(&'a StaticBlock<'a>) = AstType::StaticBlock as u8,
     ModuleDeclaration(&'a ModuleDeclaration<'a>) = AstType::ModuleDeclaration as u8,
+    AccessorProperty(&'a AccessorProperty<'a>) = AstType::AccessorProperty as u8,
     ImportExpression(&'a ImportExpression<'a>) = AstType::ImportExpression as u8,
     ImportDeclaration(&'a ImportDeclaration<'a>) = AstType::ImportDeclaration as u8,
     ImportSpecifier(&'a ImportSpecifier<'a>) = AstType::ImportSpecifier as u8,
@@ -488,6 +490,7 @@ impl GetSpan for AstKind<'_> {
             Self::PrivateIdentifier(it) => it.span(),
             Self::StaticBlock(it) => it.span(),
             Self::ModuleDeclaration(it) => it.span(),
+            Self::AccessorProperty(it) => it.span(),
             Self::ImportExpression(it) => it.span(),
             Self::ImportDeclaration(it) => it.span(),
             Self::ImportSpecifier(it) => it.span(),
@@ -988,6 +991,11 @@ impl<'a> AstKind<'a> {
         if let Self::ModuleDeclaration(v) = self { Some(v) } else { None }
     }
 
+    #[inline]
+    pub fn as_accessor_property(self) -> Option<&'a AccessorProperty<'a>> {
+        if let Self::AccessorProperty(v) = self { Some(v) } else { None }
+    }
+
     #[inline]
     pub fn as_import_expression(self) -> Option<&'a ImportExpression<'a>> {
         if let Self::ImportExpression(v) = self { Some(v) } else { None }

crates/oxc_ast_visit/src/generated/visit.rs

@@ -2645,7 +2645,8 @@ pub mod walk {
 
     #[inline]
     pub fn walk_accessor_property<'a, V: Visit<'a>>(visitor: &mut V, it: &AccessorProperty<'a>) {
-        // No `AstKind` for this type
+        let kind = AstKind::AccessorProperty(visitor.alloc(it));
+        visitor.enter_node(kind);
         visitor.visit_span(&it.span);
         visitor.visit_decorators(&it.decorators);
         visitor.visit_property_key(&it.key);
@@ -2655,6 +2656,7 @@ pub mod walk {
         if let Some(value) = &it.value {
             visitor.visit_expression(value);
         }
+        visitor.leave_node(kind);
     }
 
     #[inline]

crates/oxc_ast_visit/src/generated/visit_mut.rs

@@ -2743,7 +2743,8 @@ pub mod walk_mut {
         visitor: &mut V,
         it: &mut AccessorProperty<'a>,
     ) {
-        // No `AstType` for this type
+        let kind = AstType::AccessorProperty;
+        visitor.enter_node(kind);
         visitor.visit_span(&mut it.span);
         visitor.visit_decorators(&mut it.decorators);
         visitor.visit_property_key(&mut it.key);
@@ -2753,6 +2754,7 @@ pub mod walk_mut {
         if let Some(value) = &mut it.value {
             visitor.visit_expression(value);
         }
+        visitor.leave_node(kind);
     }
 
     #[inline]

crates/oxc_formatter/src/generated/ast_nodes.rs

@@ -106,6 +106,7 @@ pub enum AstNodes<'a> {
     PrivateIdentifier(&'a AstNode<'a, PrivateIdentifier<'a>>),
     StaticBlock(&'a AstNode<'a, StaticBlock<'a>>),
     ModuleDeclaration(&'a AstNode<'a, ModuleDeclaration<'a>>),
+    AccessorProperty(&'a AstNode<'a, AccessorProperty<'a>>),
     ImportExpression(&'a AstNode<'a, ImportExpression<'a>>),
     ImportDeclaration(&'a AstNode<'a, ImportDeclaration<'a>>),
     ImportSpecifier(&'a AstNode<'a, ImportSpecifier<'a>>),
@@ -291,6 +292,7 @@ impl<'a> AstNodes<'a> {
             Self::PrivateIdentifier(n) => n.span(),
             Self::StaticBlock(n) => n.span(),
             Self::ModuleDeclaration(n) => n.span(),
+            Self::AccessorProperty(n) => n.span(),
             Self::ImportExpression(n) => n.span(),
             Self::ImportDeclaration(n) => n.span(),
             Self::ImportSpecifier(n) => n.span(),
@@ -476,6 +478,7 @@ impl<'a> AstNodes<'a> {
             Self::PrivateIdentifier(n) => n.parent,
             Self::StaticBlock(n) => n.parent,
             Self::ModuleDeclaration(n) => n.parent,
+            Self::AccessorProperty(n) => n.parent,
             Self::ImportExpression(n) => n.parent,
             Self::ImportDeclaration(n) => n.parent,
             Self::ImportSpecifier(n) => n.parent,
@@ -661,6 +664,7 @@ impl<'a> AstNodes<'a> {
             Self::PrivateIdentifier(_) => "PrivateIdentifier",
             Self::StaticBlock(_) => "StaticBlock",
             Self::ModuleDeclaration(_) => "ModuleDeclaration",
+            Self::AccessorProperty(_) => "AccessorProperty",
             Self::ImportExpression(_) => "ImportExpression",
             Self::ImportDeclaration(_) => "ImportDeclaration",
             Self::ImportSpecifier(_) => "ImportSpecifier",
@@ -3881,9 +3885,11 @@ impl<'a> AstNode<'a, ClassElement<'a>> {
                 }))
             }
             ClassElement::AccessorProperty(s) => {
-                panic!(
-                    "No kind for current enum variant yet, please see `tasks/ast_tools/src/generators/ast_kind.rs`"
-                )
+                AstNodes::AccessorProperty(self.allocator.alloc(AstNode {
+                    inner: s.as_ref(),
+                    parent,
+                    allocator: self.allocator,
+                }))
             }
             ClassElement::TSIndexSignature(s) => {
                 panic!(
@@ -4161,7 +4167,7 @@ impl<'a> AstNode<'a, AccessorProperty<'a>> {
         self.allocator.alloc(AstNode {
             inner: &self.inner.decorators,
             allocator: self.allocator,
-            parent: self.parent,
+            parent: self.allocator.alloc(AstNodes::AccessorProperty(transmute_self(self))),
         })
     }
 
@@ -4170,7 +4176,7 @@ impl<'a> AstNode<'a, AccessorProperty<'a>> {
         self.allocator.alloc(AstNode {
             inner: &self.inner.key,
             allocator: self.allocator,
-            parent: self.parent,
+            parent: self.allocator.alloc(AstNodes::AccessorProperty(transmute_self(self))),
         })
     }
 
@@ -4180,7 +4186,7 @@ impl<'a> AstNode<'a, AccessorProperty<'a>> {
             .alloc(self.inner.type_annotation.as_ref().map(|inner| AstNode {
                 inner: inner.as_ref(),
                 allocator: self.allocator,
-                parent: self.parent,
+                parent: self.allocator.alloc(AstNodes::AccessorProperty(transmute_self(self))),
             }))
             .as_ref()
     }
@@ -4191,7 +4197,7 @@ impl<'a> AstNode<'a, AccessorProperty<'a>> {
             .alloc(self.inner.value.as_ref().map(|inner| AstNode {
                 inner,
                 allocator: self.allocator,
-                parent: self.parent,
+                parent: self.allocator.alloc(AstNodes::AccessorProperty(transmute_self(self))),
             }))
             .as_ref()
     }

crates/oxc_formatter/src/generated/format.rs

@@ -994,7 +994,10 @@ impl<'a> Format<'a> for AstNode<'a, ModuleDeclaration<'a>> {
 
 impl<'a> Format<'a> for AstNode<'a, AccessorProperty<'a>> {
     fn fmt(&self, f: &mut Formatter<'_, 'a>) -> FormatResult<()> {
-        self.write(f)
+        format_leading_comments(self.span().start).fmt(f)?;
+        let result = self.write(f);
+        format_trailing_comments(self.span().end).fmt(f)?;
+        result
     }
 }
 

tasks/ast_tools/src/generators/ast_kind.rs

@@ -35,7 +35,6 @@ const STRUCTS_BLACK_LIST: &[&str] = &[
     "AssignmentTargetPropertyProperty",
     "BindingPattern",
     "BindingProperty",
-    "AccessorProperty",
     "ImportAttribute",
     "TSInterfaceBody",
     "TSIndexSignature",