fix(linter): panic in unicorn/consistent-function-scoping (#11772)

Author: camc314

crates/oxc_linter/src/rules/unicorn/consistent_function_scoping.rs

@@ -21,7 +21,6 @@ fn consistent_function_scoping(
     parent_scope_kind: Option<&'static str>,
     function_name: Option<Atom<'_>>,
 ) -> OxcDiagnostic {
-    debug_assert!(Some(fn_span) != parent_scope_span);
     let function_label = if let Some(name) = function_name {
         format!("Function `{name}` does not capture any variables from its parent scope")
     } else {
@@ -375,7 +374,7 @@ fn get_short_span_for_fn_scope(
 
     let scope_id =
         match ctx.nodes().parent_kind(ctx.scoping().symbol_declaration(function_symbol_id)) {
-            Some(AstKind::AssignmentExpression(_)) => {
+            Some(AstKind::AssignmentExpression(_) | AstKind::ObjectProperty(_)) => {
                 ctx.scoping().scope_parent_id(scope_id).unwrap_or(scope_id)
             }
             _ => scope_id,
@@ -988,6 +987,10 @@ fn test() {
             "export namespace Foo { export function outer() { const inner = function inner() {}; } }",
             None,
         ),
+        (
+            "jest.mock('@kbn/i18n-react', () => { return { I18nProvider: function MockI18nProvider() { }, }; });",
+            None,
+        ),
     ];
 
     Tester::new(ConsistentFunctionScoping::NAME, ConsistentFunctionScoping::PLUGIN, pass, fail)

crates/oxc_linter/src/snapshots/unicorn_consistent_function_scoping.snap

@@ -541,3 +541,10 @@ source: crates/oxc_linter/src/tester.rs
    ·                                          ╰── Outer scope where this function is defined
    ╰────
   help: Move `inner` to the outer scope to avoid recreating it on every call.
+
+  ⚠ eslint-plugin-unicorn(consistent-function-scoping): Function `MockI18nProvider` does not capture any variables from its parent scope
+   ╭─[consistent_function_scoping.tsx:1:70]
+ 1 │ jest.mock('@kbn/i18n-react', () => { return { I18nProvider: function MockI18nProvider() { }, }; });
+   ·                                                                      ────────────────
+   ╰────
+  help: Move `MockI18nProvider` to the outer scope to avoid recreating it on every call.