fix(semantic): flag super in function inside ObjectExpression

Author: overlookmotel

crates/oxc_semantic/src/checker/javascript.rs

@@ -3,6 +3,7 @@ use std::ptr;
 use phf::{Set, phf_set};
 use rustc_hash::FxHashMap;
 
+use oxc_allocator::GetAddress;
 use oxc_ast::{AstKind, ModuleDeclarationKind, ast::*};
 use oxc_diagnostics::{LabeledSpan, OxcDiagnostic};
 use oxc_ecmascript::{BoundNames, IsSimpleParameterList, PropName};
@@ -900,16 +901,24 @@ pub fn check_super(sup: &Super, ctx: &SemanticBuilder<'_>) {
         // Not in a class. `super` only valid in an object method.
         for scope_id in ctx.scoping.scope_ancestors(ctx.current_scope_id) {
             let flags = ctx.scoping.scope_flags(scope_id);
-            if flags.is_function()
-                && matches!(
-                    ctx.nodes.parent_kind(ctx.scoping.get_node_id(scope_id)),
-                    AstKind::ObjectProperty(_)
-                )
-            {
-                if let Some(super_call_span) = super_call_span {
-                    ctx.error(unexpected_super_call(super_call_span));
+            if flags.is_function() && !flags.is_arrow() {
+                let func_node_id = ctx.scoping.get_node_id(scope_id);
+                if let AstKind::ObjectProperty(prop) = ctx.nodes.parent_kind(func_node_id) {
+                    if prop.method || prop.kind != PropertyKind::Init {
+                        // Function's parent is an `ObjectProperty` representing a method/getter/setter.
+                        // Check the function is the value of the property, not computed key.
+                        // Valid: `obj = { method() { super.foo } }`
+                        // Invalid: `obj = { [ function() { super.foo } ]() {} }`
+                        let func_kind = ctx.nodes.kind(func_node_id);
+                        if func_kind.address() == prop.value.address() {
+                            if let Some(super_call_span) = super_call_span {
+                                ctx.error(unexpected_super_call(super_call_span));
+                            }
+                            return;
+                        }
+                    }
                 }
-                return;
+                break;
             }
         }
 

tasks/coverage/misc/fail/oxc-13323.js

@@ -0,0 +1,19 @@
+o = {
+  foo: function() {
+    super.foo;
+  },
+};
+
+o = {
+  foo() {
+    return function() {
+      super.foo;
+    };
+  },
+};
+
+o = {
+  [ function() { super.foo; } ]() {},
+  get [ function() { super.foo; } ]() {},
+  set [ function() { super.foo; } ](v) {},
+};

tasks/coverage/snapshots/parser_babel.snap

@@ -3,7 +3,7 @@ commit: 41d96516
 parser_babel Summary:
 AST Parsed     : 2407/2423 (99.34%)
 Positive Passed: 2385/2423 (98.43%)
-Negative Passed: 1642/1755 (93.56%)
+Negative Passed: 1643/1755 (93.62%)
 Expect Syntax Error: tasks/coverage/babel/packages/babel-parser/test/fixtures/core/categorized/invalid-startindex-and-startline-specified-without-startcolumn/input.js
 
 Expect Syntax Error: tasks/coverage/babel/packages/babel-parser/test/fixtures/core/categorized/startline-and-startcolumn-specified/input.js
@@ -20,8 +20,6 @@ Expect Syntax Error: tasks/coverage/babel/packages/babel-parser/test/fixtures/co
 
 Expect Syntax Error: tasks/coverage/babel/packages/babel-parser/test/fixtures/core/sourcetype-commonjs/invalid-allowReturnOutsideFunction-true/input.js
 
-Expect Syntax Error: tasks/coverage/babel/packages/babel-parser/test/fixtures/es2015/class-methods/direct-super-in-object-method/input.js
-
 Expect Syntax Error: tasks/coverage/babel/packages/babel-parser/test/fixtures/es2015/destructuring/error-operator-for-default/input.js
 
 Expect Syntax Error: tasks/coverage/babel/packages/babel-parser/test/fixtures/es2015/for-of/invalid-let-as-identifier/input.js
@@ -2969,6 +2967,14 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
    ·           ───────────
    ╰────
 
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+   ╭─[babel/packages/babel-parser/test/fixtures/es2015/class-methods/direct-super-in-object-method/input.js:4:14]
+ 3 │     get: function(){
+ 4 │       return super.foo;
+   ·              ─────
+ 5 │     }
+   ╰────
+
   × Super calls are not permitted outside constructors or in nested functions inside constructors.
    ╭─[babel/packages/babel-parser/test/fixtures/es2015/class-methods/direct-super-outside-constructor/input.js:2:9]
  1 │ class A {

tasks/coverage/snapshots/parser_misc.snap

@@ -1,7 +1,7 @@
 parser_misc Summary:
 AST Parsed     : 47/47 (100.00%)
 Positive Passed: 47/47 (100.00%)
-Negative Passed: 55/55 (100.00%)
+Negative Passed: 56/56 (100.00%)
 
   × Cannot assign to 'arguments' in strict mode
    ╭─[misc/fail/arguments-eval.ts:1:10]
@@ -235,6 +235,46 @@ Negative Passed: 55/55 (100.00%)
  6 │       },
    ╰────
 
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+   ╭─[misc/fail/oxc-13323.js:3:5]
+ 2 │   foo: function() {
+ 3 │     super.foo;
+   ·     ─────
+ 4 │   },
+   ╰────
+
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[misc/fail/oxc-13323.js:10:7]
+  9 │     return function() {
+ 10 │       super.foo;
+    ·       ─────
+ 11 │     };
+    ╰────
+
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[misc/fail/oxc-13323.js:16:18]
+ 15 │ o = {
+ 16 │   [ function() { super.foo; } ]() {},
+    ·                  ─────
+ 17 │   get [ function() { super.foo; } ]() {},
+    ╰────
+
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[misc/fail/oxc-13323.js:17:22]
+ 16 │   [ function() { super.foo; } ]() {},
+ 17 │   get [ function() { super.foo; } ]() {},
+    ·                      ─────
+ 18 │   set [ function() { super.foo; } ](v) {},
+    ╰────
+
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[misc/fail/oxc-13323.js:18:22]
+ 17 │   get [ function() { super.foo; } ]() {},
+ 18 │   set [ function() { super.foo; } ](v) {},
+    ·                      ─────
+ 19 │ };
+    ╰────
+
   × Unexpected token
    ╭─[misc/fail/oxc-169.js:2:1]
  1 │ 1<(V=82<<t-j0<(V=$<LBI<(V=ut<I<(V=$<LBI<(V=uIV=82<<t-j0<(V=$<LBI<(V=ut<I<(V=$<LBI<(V<II>

tasks/coverage/snapshots/parser_typescript.snap

@@ -12963,6 +12963,30 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
     ╰────
   help: replace with `super()` or `super.prop` or `super[prop]`
 
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[typescript/tests/cases/compiler/superInObjectLiterals_ES5.ts:17:9]
+ 16 │     p1: function () {
+ 17 │         super.method();
+    ·         ─────
+ 18 │     },
+    ╰────
+
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[typescript/tests/cases/compiler/superInObjectLiterals_ES5.ts:20:9]
+ 19 │     p2: function f() {
+ 20 │         super.method();
+    ·         ─────
+ 21 │     },
+    ╰────
+
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[typescript/tests/cases/compiler/superInObjectLiterals_ES5.ts:23:9]
+ 22 │     p3: () => {
+ 23 │         super.method();
+    ·         ─────
+ 24 │     }
+    ╰────
+
   × 'super' can only be referenced in members of derived classes or object literal expressions.
     ╭─[typescript/tests/cases/compiler/superInObjectLiterals_ES5.ts:39:17]
  38 │             method() {
@@ -13003,6 +13027,30 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
  53 │             },
     ╰────
 
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[typescript/tests/cases/compiler/superInObjectLiterals_ES6.ts:17:9]
+ 16 │     p1: function () {
+ 17 │         super.method();
+    ·         ─────
+ 18 │     },
+    ╰────
+
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[typescript/tests/cases/compiler/superInObjectLiterals_ES6.ts:20:9]
+ 19 │     p2: function f() {
+ 20 │         super.method();
+    ·         ─────
+ 21 │     },
+    ╰────
+
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[typescript/tests/cases/compiler/superInObjectLiterals_ES6.ts:23:9]
+ 22 │     p3: () => {
+ 23 │         super.method();
+    ·         ─────
+ 24 │     }
+    ╰────
+
   × 'super' can only be referenced in members of derived classes or object literal expressions.
     ╭─[typescript/tests/cases/compiler/superInObjectLiterals_ES6.ts:39:17]
  38 │             method() {
@@ -13070,6 +13118,14 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
    ╰────
   help: replace with `super()` or `super.prop` or `super[prop]`
 
+  × 'super' can only be referenced in members of derived classes or object literal expressions.
+    ╭─[typescript/tests/cases/compiler/super_inside-object-literal-getters-and-setters.ts:11:20]
+ 10 │         test: function () {
+ 11 │             return super._foo;
+    ·                    ─────
+ 12 │         }
+    ╰────
+
   × 'super' can only be referenced in members of derived classes or object literal expressions.
     ╭─[typescript/tests/cases/compiler/super_inside-object-literal-getters-and-setters.ts:21:24]
  20 │             get F() {