Skip to content

Commit cd5a460

Browse files
committed
fix(oxc_formatter): Fix arrow_parentheses: 'avoid' > 'as-needed'
1 parent 5ee24d5 commit cd5a460

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

crates/oxc_formatter/src/options.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,8 +596,7 @@ impl FromStr for ArrowParentheses {
596596

597597
fn from_str(s: &str) -> Result<Self, Self::Err> {
598598
match s {
599-
// Prettier calls it `avoid`, but Biome calls it `AsNeeded`
600-
"avoid" => Ok(Self::AsNeeded),
599+
"as-needed" => Ok(Self::AsNeeded),
601600
"always" => Ok(Self::Always),
602601
_ => Err(
603602
"Value not supported for Arrow parentheses. Supported values are 'as-needed' and 'always'.",

tasks/prettier_conformance/src/spec.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,11 @@ impl VisitMut<'_> for SpecParser {
187187
}
188188
"arrowParens" => {
189189
// TODO: change `unwrap_or_default` to `unwrap`
190-
options.arrow_parentheses =
191-
ArrowParentheses::from_str(s).unwrap_or_default();
190+
options.arrow_parentheses = ArrowParentheses::from_str(
191+
// Prettier uses "avoid", but we use "as-needed"
192+
if s == "avoid" { "as-needed" } else { s },
193+
)
194+
.unwrap_or_default();
192195
}
193196
"experimentalOperatorPosition" => {
194197
// TODO: change `unwrap_or_default` to `unwrap`

0 commit comments

Comments
 (0)