chore(rust): MSRV 1.88.0 (#13977)

This broke the linter ast nodes detector

Author: Boshen

Cargo.toml

@@ -15,7 +15,7 @@ description = "A collection of JavaScript tools written in Rust."
 edition = "2024"
 # MSRV Policy N-2 (12 weeks).
 # Balance between the core contributors enjoying the latest version of rustc, while waiting for dependents to catch up.
-rust-version = "1.87.0"
+rust-version = "1.88.0"
 
 # <https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html>
 [workspace.lints.rust]

apps/oxfmt/src/walk.rs

@@ -33,17 +33,16 @@ impl ignore::ParallelVisitor for WalkVisitor {
         match entry {
             Ok(entry) => {
                 // Skip if we can't get file type or if it's a directory
-                if let Some(file_type) = entry.file_type() {
-                    if !file_type.is_dir() {
-                        if let Some(source_type) = get_supported_source_type(entry.path()) {
-                            let walk_entry =
-                                WalkEntry { path: entry.path().as_os_str().into(), source_type };
-                            // Send each entry immediately through the channel
-                            // If send fails, the receiver has been dropped, so stop walking
-                            if self.sender.send(walk_entry).is_err() {
-                                return ignore::WalkState::Quit;
-                            }
-                        }
+                if let Some(file_type) = entry.file_type()
+                    && !file_type.is_dir()
+                    && let Some(source_type) = get_supported_source_type(entry.path())
+                {
+                    let walk_entry =
+                        WalkEntry { path: entry.path().as_os_str().into(), source_type };
+                    // Send each entry immediately through the channel
+                    // If send fails, the receiver has been dropped, so stop walking
+                    if self.sender.send(walk_entry).is_err() {
+                        return ignore::WalkState::Quit;
                     }
                 }
                 ignore::WalkState::Continue

crates/oxc_allocator/src/vec2/raw_vec.rs

@@ -815,10 +815,10 @@ impl<T, A: Alloc> RawVec<'_, T, A> {
     /// Not sure what safety invariants of this method are! TODO
     pub unsafe fn dealloc_buffer(&mut self) {
         let elem_size = mem::size_of::<T>();
-        if elem_size != 0 {
-            if let Some(layout) = self.current_layout() {
-                self.alloc.dealloc(self.ptr.cast(), layout);
-            }
+        if elem_size != 0
+            && let Some(layout) = self.current_layout()
+        {
+            self.alloc.dealloc(self.ptr.cast(), layout);
         }
     }
 }

crates/oxc_ast/src/ast_impl/js.rs

@@ -1537,20 +1537,20 @@ impl FunctionBody<'_> {
 impl<'a> ArrowFunctionExpression<'a> {
     /// Get expression part of `ArrowFunctionExpression`: `() => expression_part`.
     pub fn get_expression(&self) -> Option<&Expression<'a>> {
-        if self.expression {
-            if let Statement::ExpressionStatement(expr_stmt) = &self.body.statements[0] {
-                return Some(&expr_stmt.expression);
-            }
+        if self.expression
+            && let Statement::ExpressionStatement(expr_stmt) = &self.body.statements[0]
+        {
+            return Some(&expr_stmt.expression);
         }
         None
     }
 
     /// Get expression part of `ArrowFunctionExpression`: `() => expression_part`.
     pub fn get_expression_mut(&mut self) -> Option<&mut Expression<'a>> {
-        if self.expression {
-            if let Statement::ExpressionStatement(expr_stmt) = &mut self.body.statements[0] {
-                return Some(&mut expr_stmt.expression);
-            }
+        if self.expression
+            && let Statement::ExpressionStatement(expr_stmt) = &mut self.body.statements[0]
+        {
+            return Some(&mut expr_stmt.expression);
         }
         None
     }

crates/oxc_ast/src/ast_impl/literal.rs

@@ -87,10 +87,10 @@ impl StringLiteral<'_> {
         while let Some(c) = chars.next() {
             if c == '\\' && chars.next() == Some('u') {
                 let hex = &chars.as_str()[..4];
-                if let Ok(hex) = u32::from_str_radix(hex, 16) {
-                    if (0xd800..=0xdfff).contains(&hex) {
-                        return false;
-                    }
+                if let Ok(hex) = u32::from_str_radix(hex, 16)
+                    && (0xd800..=0xdfff).contains(&hex)
+                {
+                    return false;
                 }
             }
         }

crates/oxc_ast/src/ast_impl/ts.rs

@@ -94,10 +94,10 @@ impl<'a> TSTypeName<'a> {
 
     /// Returns `true` if this is a reference to `const`.
     pub fn is_const(&self) -> bool {
-        if let TSTypeName::IdentifierReference(ident) = self {
-            if ident.name == "const" {
-                return true;
-            }
+        if let TSTypeName::IdentifierReference(ident) = self
+            && ident.name == "const"
+        {
+            return true;
         }
         false
     }

crates/oxc_ast_macros/src/ast.rs

@@ -64,10 +64,10 @@ fn modify_struct(item: &mut ItemStruct, args: TokenStream) -> TokenStream {
 /// Mutates `item` in place, re-ordering its fields.
 fn reorder_struct_fields(item: &mut ItemStruct, args: TokenStream) -> Result<(), &'static str> {
     // Skip foreign types
-    if let Some(TokenTree::Ident(ident)) = args.into_iter().next() {
-        if ident == "foreign" {
-            return Ok(());
-        }
+    if let Some(TokenTree::Ident(ident)) = args.into_iter().next()
+        && ident == "foreign"
+    {
+        return Ok(());
     }
 
     // Get struct data

crates/oxc_cfg/src/builder/context.rs

@@ -132,12 +132,11 @@ impl<'a, 'c> QueryCtx<'a, 'c> {
 
         // mark the upper label continue jump point the same as ours if it isn't already assigned,
         // NOTE: if it is already assigned there's a resolution before this context.
-        if let Some(jmp) = continue_jmp {
-            if let Some(label_ctx @ RefCtxCursor(Ctx { continue_jmp: None, .. })) =
+        if let Some(jmp) = continue_jmp
+            && let Some(label_ctx @ RefCtxCursor(Ctx { continue_jmp: None, .. })) =
                 self.0.immediate_labeled_ctx()
-            {
-                label_ctx.mark_continue(jmp);
-            }
+        {
+            label_ctx.mark_continue(jmp);
         }
     }
 

crates/oxc_codegen/src/binary_expr_visitor.rs

@@ -186,15 +186,15 @@ impl<'a> BinaryExpressionVisitor<'a> {
 
         match self.operator {
             BinaryishOperator::Logical(LogicalOperator::Coalesce) => {
-                if let Expression::LogicalExpression(logical_expr) = e.left() {
-                    if matches!(logical_expr.operator, LogicalOperator::And | LogicalOperator::Or) {
-                        self.left_precedence = Precedence::Prefix;
-                    }
+                if let Expression::LogicalExpression(logical_expr) = e.left()
+                    && matches!(logical_expr.operator, LogicalOperator::And | LogicalOperator::Or)
+                {
+                    self.left_precedence = Precedence::Prefix;
                 }
-                if let Expression::LogicalExpression(logical_expr) = e.right() {
-                    if matches!(logical_expr.operator, LogicalOperator::And | LogicalOperator::Or) {
-                        self.right_precedence = Precedence::Prefix;
-                    }
+                if let Expression::LogicalExpression(logical_expr) = e.right()
+                    && matches!(logical_expr.operator, LogicalOperator::And | LogicalOperator::Or)
+                {
+                    self.right_precedence = Precedence::Prefix;
                 }
             }
             BinaryishOperator::Binary(BinaryOperator::Exponential) => {

crates/oxc_codegen/src/gen.rs

@@ -945,10 +945,11 @@ impl Gen for ImportAttribute<'_> {
 impl Gen for ExportNamedDeclaration<'_> {
     fn r#gen(&self, p: &mut Codegen, ctx: Context) {
         p.print_comments_at(self.span.start);
-        if let Some(Declaration::FunctionDeclaration(func)) = &self.declaration {
-            if func.pure && p.options.print_annotation_comment() {
-                p.print_str(NO_SIDE_EFFECTS_NEW_LINE_COMMENT);
-            }
+        if let Some(Declaration::FunctionDeclaration(func)) = &self.declaration
+            && func.pure
+            && p.options.print_annotation_comment()
+        {
+            p.print_str(NO_SIDE_EFFECTS_NEW_LINE_COMMENT);
         }
         p.add_source_mapping(self.span);
         p.print_indent();
@@ -1092,10 +1093,11 @@ impl Gen for ExportAllDeclaration<'_> {
 impl Gen for ExportDefaultDeclaration<'_> {
     fn r#gen(&self, p: &mut Codegen, ctx: Context) {
         p.print_comments_at(self.span.start);
-        if let ExportDefaultDeclarationKind::FunctionDeclaration(func) = &self.declaration {
-            if func.pure && p.options.print_annotation_comment() {
-                p.print_str(NO_SIDE_EFFECTS_NEW_LINE_COMMENT);
-            }
+        if let ExportDefaultDeclarationKind::FunctionDeclaration(func) = &self.declaration
+            && func.pure
+            && p.options.print_annotation_comment()
+        {
+            p.print_str(NO_SIDE_EFFECTS_NEW_LINE_COMMENT);
         }
         p.add_source_mapping(self.span);
         p.print_indent();
@@ -1586,23 +1588,22 @@ impl Gen for ObjectProperty<'_> {
         if let PropertyKey::StaticIdentifier(key) = &self.key {
             if key.name == "__proto__" {
                 shorthand = self.shorthand;
-            } else if let Expression::Identifier(ident) = self.value.without_parentheses() {
-                if key.name == p.get_identifier_reference_name(ident) {
-                    shorthand = true;
-                }
+            } else if let Expression::Identifier(ident) = self.value.without_parentheses()
+                && key.name == p.get_identifier_reference_name(ident)
+            {
+                shorthand = true;
             }
         }
 
         let mut computed = self.computed;
 
         // "{ -1: 0 }" must be printed as "{ [-1]: 0 }"
         // "{ 1/0: 0 }" must be printed as "{ [1/0]: 0 }"
-        if !computed {
-            if let Some(Expression::NumericLiteral(n)) = self.key.as_expression() {
-                if n.value.is_sign_negative() || n.value.is_infinite() {
-                    computed = true;
-                }
-            }
+        if !computed
+            && let Some(Expression::NumericLiteral(n)) = self.key.as_expression()
+            && (n.value.is_sign_negative() || n.value.is_infinite())
+        {
+            computed = true;
         }
 
         if !shorthand {
@@ -2811,10 +2812,9 @@ impl Gen for BindingProperty<'_> {
                 BindingPatternKind::AssignmentPattern(assignment_pattern) => {
                     if let BindingPatternKind::BindingIdentifier(ident) =
                         &assignment_pattern.left.kind
+                        && key.name == p.get_binding_identifier_name(ident)
                     {
-                        if key.name == p.get_binding_identifier_name(ident) {
-                            shorthand = true;
-                        }
+                        shorthand = true;
                     }
                 }
                 _ => {}
@@ -3205,12 +3205,12 @@ impl Gen for TSTemplateLiteralType<'_> {
     fn r#gen(&self, p: &mut Codegen, ctx: Context) {
         p.print_str("`");
         for (index, item) in self.quasis.iter().enumerate() {
-            if index != 0 {
-                if let Some(types) = self.types.get(index - 1) {
-                    p.print_str("${");
-                    types.print(p, ctx);
-                    p.print_str("}");
-                }
+            if index != 0
+                && let Some(types) = self.types.get(index - 1)
+            {
+                p.print_str("${");
+                types.print(p, ctx);
+                p.print_str("}");
             }
             p.print_str(item.value.raw.as_str());
         }