feat(editor): add off to oxc.lint.run configuration

Author: Sysix

editors/vscode/client/WorkspaceConfig.ts

@@ -3,7 +3,7 @@ import { ConfigService } from './ConfigService';
 
 export const oxlintConfigFileName = '.oxlintrc.json';
 
-export type Trigger = 'onSave' | 'onType';
+export type Trigger = 'onSave' | 'onType' | 'off';
 
 type UnusedDisableDirectives = 'allow' | 'warn' | 'deny';
 

editors/vscode/fixtures/disabling_lint/debugger.js

@@ -0,0 +1 @@
+/* 😊 */debugger;

editors/vscode/package.json

@@ -69,7 +69,8 @@
           "type": "string",
           "enum": [
             "onSave",
-            "onType"
+            "onType",
+            "off"
           ],
           "default": "onType",
           "description": "Run the linter on save (onSave) or on type (onType)"

editors/vscode/tests/e2e_server.spec.ts

@@ -32,6 +32,7 @@ suiteSetup(async () => {
 });
 
 teardown(async () => {
+  await workspace.getConfiguration('oxc').update('lint.run', undefined);
   await workspace.getConfiguration('oxc').update('flags', undefined);
   await workspace.getConfiguration('oxc').update('tsConfigPath', undefined);
   await workspace.getConfiguration('oxc').update('typeAware', undefined);
@@ -74,7 +75,6 @@ suite('E2E Diagnostics', () => {
   testSingleFolderMode('detects diagnostics on run', async () =>
   {
     await loadFixture('lint_on_run');
-    await sleep(250);
     const diagnostics = await getDiagnosticsWithoutClose(`onType.ts`);
     strictEqual(diagnostics.length, 0);
 
@@ -92,7 +92,6 @@ suite('E2E Diagnostics', () => {
 
   test('empty oxlint configuration behaves like default configuration', async () => {
     await loadFixture('debugger_empty_config');
-    await sleep(250);
     const diagnostics = await getDiagnostics('debugger.js');
 
     strictEqual(diagnostics.length, 1);
@@ -194,6 +193,39 @@ suite('E2E Diagnostics', () => {
     strictEqual(nestedDiagnostics[0].severity, DiagnosticSeverity.Error);
   });
 
+
+  test('setting `oxc.lint.run` to `off` clears diagnostics', async () => {
+    await workspace.getConfiguration('oxc').update('lint.run', undefined);
+    await loadFixture('disabling_lint');
+    await sleep(250);
+    const firstDiagnostics = await getDiagnosticsWithoutClose('debugger.js');
+
+    strictEqual(firstDiagnostics.length, 1);
+
+    await workspace.getConfiguration('oxc').update('lint.run', 'off');
+    await workspace.saveAll();
+    await waitForDiagnosticChange();
+
+    const secondDiagnostics = await getDiagnostics('debugger.js');
+    strictEqual(secondDiagnostics.length, 0);
+  });
+
+  test('setting `oxc.lint.run` from `off` to `onType`, shows the diagnostics', async () => {
+    await workspace.getConfiguration('oxc').update('lint.run', "off");
+    await loadFixture('disabling_lint');
+    await sleep(250);
+    const firstDiagnostics = await getDiagnosticsWithoutClose('debugger.js');
+
+    strictEqual(firstDiagnostics.length, 0);
+
+    await workspace.getConfiguration('oxc').update('lint.run', 'onType');
+    await workspace.saveAll();
+    await waitForDiagnosticChange();
+
+    const secondDiagnostics = await getDiagnostics('debugger.js');
+    strictEqual(secondDiagnostics.length, 1);
+  });
+
   // somehow this test is flaky in CI
   // testMultiFolderMode('different diagnostic severity', async () => {
   //   await loadFixture('debugger', WORKSPACE_DIR);