fix(formatter): decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029)

Author: Dunqing

crates/oxc_formatter/src/utils/assignment_like.rs

@@ -233,6 +233,8 @@ impl<'a> AssignmentLike<'a, '_> {
                 }
             }
             AssignmentLike::PropertyDefinition(property) => {
+                write!(f, [property.decorators()])?;
+
                 if property.declare {
                     write!(f, ["declare", space()])?;
                 }

crates/oxc_formatter/src/write/class.rs

@@ -54,25 +54,14 @@ impl<'a> Format<'a> for AstNode<'a, Vec<'a, ClassElement<'a>>> {
 
 impl<'a> Format<'a> for (&AstNode<'a, ClassElement<'a>>, Option<&AstNode<'a, ClassElement<'a>>>) {
     fn fmt(&self, f: &mut Formatter<'_, 'a>) -> FormatResult<()> {
-        let decorators = match self.0.as_ast_nodes() {
-            AstNodes::MethodDefinition(method) => {
-                write!(f, [method.decorators(), method])
-            }
-            AstNodes::PropertyDefinition(property) => {
-                write!(f, [property.decorators(), property])
-            }
-            AstNodes::AccessorProperty(accessor) => {
-                write!(f, [accessor.decorators(), accessor])
-            }
-            _ => write!(f, self.0),
-        };
-
-        write!(f, [ClassPropertySemicolon::new(self.0, self.1)])
+        write!(f, [self.0, ClassPropertySemicolon::new(self.0, self.1)])
     }
 }
 
 impl<'a> FormatWrite<'a> for AstNode<'a, MethodDefinition<'a>> {
     fn write(&self, f: &mut Formatter<'_, 'a>) -> FormatResult<()> {
+        write!(f, [self.decorators()])?;
+
         if let Some(accessibility) = &self.accessibility {
             write!(f, [accessibility.as_str(), space()])?;
         }
@@ -160,6 +149,8 @@ impl<'a> FormatWrite<'a> for AstNode<'a, StaticBlock<'a>> {
 
 impl<'a> FormatWrite<'a> for AstNode<'a, AccessorProperty<'a>> {
     fn write(&self, f: &mut Formatter<'_, 'a>) -> FormatResult<()> {
+        write!(f, [self.decorators()])?;
+
         if let Some(accessibility) = self.accessibility() {
             write!(f, [accessibility.as_str(), space()])?;
         }

crates/oxc_formatter/src/write/decorators.rs

@@ -73,7 +73,6 @@ fn is_identifier_or_static_member_only(callee: &Expression) -> bool {
 
 impl<'a> FormatWrite<'a> for AstNode<'a, Decorator<'a>> {
     fn write(&self, f: &mut Formatter<'_, 'a>) -> FormatResult<()> {
-        self.format_leading_comments(f)?;
         write!(f, ["@"]);
 
         // Determine if parentheses are required around decorator expressions

crates/oxc_formatter/tests/fixtures/ts/class/decorators.ts

@@ -0,0 +1,4 @@
+class A {
+  // comment shouldn't break the decorators grouping
+  @memoize onContextMenu() { }
+}

crates/oxc_formatter/tests/fixtures/ts/class/decorators.ts.snap

@@ -0,0 +1,16 @@
+---
+source: crates/oxc_formatter/tests/fixtures/mod.rs
+---
+==================== Input ====================
+class A {
+  // comment shouldn't break the decorators grouping
+  @memoize onContextMenu() { }
+}
+
+==================== Output ====================
+class A {
+  // comment shouldn't break the decorators grouping
+  @memoize onContextMenu() {}
+}
+
+===================== End =====================