fix(parser,linter): consider typescript declarations for named exports (#10532)

Only VariableDeclaration, FunctionDeclaration and ClassDeclaration were
considered when collecting named export declarations for the module
record. Now the parser also considers TSTypeAliasDeclaration,
TSInterfaceDeclaration, TSEnumDeclaration, TSImportEqualsDeclaration and
TSModuleDeclaration named export declarations of the module.

Maybe the other `decl.declaration.is_typescript_syntax()` check in
`module_record.rs` also needs to be removed?

Closes #10318
Closes #10556

Author: ulrichstark

crates/oxc_linter/fixtures/import/typescript-export-enum.ts

@@ -0,0 +1,3 @@
+export enum Foo {
+  BAR = 0,
+}

crates/oxc_linter/src/rules/import/namespace.rs

@@ -485,6 +485,11 @@ fn test() {
         (r"import { a } from './oxc/indirect-export'; console.log(a.nothing)", None),
         // Issue: <https://github.com/oxc-project/oxc/issues/7696>
         (r"import * as acorn from 'acorn'; acorn.parse()", None),
+        // https://github.com/oxc-project/oxc/issues/10318
+        (
+            r#"import * as lib from "./typescript-export-enum"; export const bar = lib.Foo.BAR;"#,
+            None,
+        ),
     ];
 
     let fail = vec![

crates/oxc_parser/src/module_record.rs

@@ -317,11 +317,6 @@ impl<'a> ModuleRecordBuilder<'a> {
     }
 
     fn visit_export_named_declaration(&mut self, decl: &ExportNamedDeclaration<'a>) {
-        // ignore all TypeScript syntax as they overload
-        if decl.declaration.as_ref().is_some_and(Declaration::is_typescript_syntax) {
-            return;
-        }
-
         let module_request =
             decl.source.as_ref().map(|source| NameSpan::new(source.value, source.span));
 
@@ -338,7 +333,7 @@ impl<'a> ModuleRecordBuilder<'a> {
         }
 
         if let Some(d) = &decl.declaration {
-            d.bound_names(&mut |ident| {
+            iter_binding_identifiers_of_declaration(d, &mut |ident| {
                 let export_name = ExportExportName::Name(NameSpan::new(ident.name, ident.span));
                 let local_name = ExportLocalName::Name(NameSpan::new(ident.name, ident.span));
                 let export_entry = ExportEntry {
@@ -388,6 +383,17 @@ impl<'a> ModuleRecordBuilder<'a> {
     }
 }
 
+fn iter_binding_identifiers_of_declaration<'a, F>(decl: &Declaration<'a>, f: &mut F)
+where
+    F: FnMut(&BindingIdentifier<'a>),
+{
+    if let Declaration::VariableDeclaration(decl) = decl {
+        decl.bound_names(f);
+    } else if let Some(ident) = decl.id() {
+        f(ident);
+    }
+}
+
 #[cfg(test)]
 mod module_record_tests {
     use oxc_allocator::Allocator;

napi/parser/test/esm.test.ts

@@ -84,17 +84,20 @@ describe('hasModuleSyntax', () => {
 });
 
 describe('export type', () => {
-  const code = [
-    "export type * from 'mod'",
-    "export type * as ns from 'mod'",
-    'export type { foo }',
-    'export { type foo }',
-    "export type { foo } from 'mod'",
-  ];
-  test.each(code)('%s', (s) => {
-    const ret = parseSync('test.ts', s);
+  const inputs = [
+    ["export type * from 'mod'", true],
+    ["export type * as ns from 'mod'", true],
+    ['export type { foo }', true],
+    ['export { type foo }', true],
+    ["export type { foo } from 'mod'", true],
+    ['export type Foo = {}', true],
+    ['export interface Bar {}', true],
+    ['export namespace Baz {}', false], // namespace isn't considered a typed export
+  ] as const;
+  test.each(inputs)('%s', (source, isType) => {
+    const ret = parseSync('test.ts', source);
     expect(ret.module.staticExports.length).toBe(1);
     expect(ret.module.staticExports[0].entries.length).toBe(1);
-    expect(ret.module.staticExports[0].entries[0].isType).toBe(true);
+    expect(ret.module.staticExports[0].entries[0].isType).toBe(isType);
   });
 });

tasks/coverage/snapshots/parser_typescript.snap

@@ -3,7 +3,7 @@ commit: 15392346
 parser_typescript Summary:
 AST Parsed     : 6523/6531 (99.88%)
 Positive Passed: 6511/6531 (99.69%)
-Negative Passed: 1308/5754 (22.73%)
+Negative Passed: 1309/5754 (22.75%)
 Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/ClassDeclaration24.ts
 
 Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/ExportAssignment7.ts
@@ -2540,8 +2540,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocTypeNon
 
 Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocTypedefMissingType.ts
 
-Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsdocTypedefNoCrash2.ts
-
 Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsxCallElaborationCheckNoCrash1.tsx
 
 Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsxChildWrongType.tsx
@@ -13415,6 +13413,20 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/salsa/private
    ╰────
   help: Try insert a semicolon here
 
+  × Duplicated export 'foo'
+   ╭─[typescript/tests/cases/compiler/jsdocTypedefNoCrash2.ts:1:13]
+ 1 │ export type foo = 5;
+   ·             ─┬─
+   ·              ╰── Export has already been declared here
+ 2 │ /**
+   ╰────
+   ╭─[typescript/tests/cases/compiler/jsdocTypedefNoCrash2.ts:6:14]
+ 5 │  */
+ 6 │ export const foo = 5;
+   ·              ─┬─
+   ·               ╰── It cannot be redeclared here
+   ╰────
+
   × Unexpected token
    ╭─[typescript/tests/cases/compiler/jsxAttributeMissingInitializer.tsx:1:21]
  1 │ const x = <div foo= ></div>;