perf:

Author: liangmiQwQ

crates/oxc_linter/src/loader/partial_loader/astro.rs

@@ -1,8 +1,11 @@
-use memchr::memmem::Finder;
+use memchr::memmem::{Finder, FinderRev};
 
 use oxc_span::{SourceType, Span};
 
-use crate::loader::{JavaScriptSource, partial_loader::find_script_start};
+use crate::loader::{
+    JavaScriptSource,
+    partial_loader::{COMMENT_END, COMMENT_START, SCRIPT_START, find_script_start},
+};
 
 use super::SCRIPT_END;
 
@@ -53,7 +56,10 @@ impl<'a> AstroPartialLoader<'a> {
     /// In .astro files, you can add client-side JavaScript by adding one (or more) `<script>` tags.
     /// <https://docs.astro.build/en/guides/client-side-scripts/#using-script-in-astro>
     fn parse_scripts(&self, start: usize) -> Vec<JavaScriptSource<'a>> {
+        let script_start_finder = Finder::new(SCRIPT_START);
         let script_end_finder = Finder::new(SCRIPT_END);
+        let comment_start_finder = FinderRev::new(COMMENT_START);
+        let comment_end_finder = Finder::new(COMMENT_END);
 
         let mut results = vec![];
         let mut pointer = start;
@@ -62,7 +68,13 @@ impl<'a> AstroPartialLoader<'a> {
             let js_start;
             let js_end;
             // find opening "<script"
-            if let Some(offset) = find_script_start(self.source_text, &pointer) {
+            if let Some(offset) = find_script_start(
+                self.source_text,
+                pointer,
+                &script_start_finder,
+                &comment_start_finder,
+                &comment_end_finder,
+            ) {
                 pointer += offset;
             } else {
                 break;

crates/oxc_linter/src/loader/partial_loader/mod.rs

@@ -73,11 +73,14 @@ fn find_script_closing_angle(source_text: &str, pointer: usize) -> Option<usize>
     None
 }
 
-fn find_script_start(source_text: &str, pointer: &usize) -> Option<usize> {
-    let mut new_pointer = *pointer;
-    let script_start_finder = Finder::new(SCRIPT_START);
-    let comment_start_finder = FinderRev::new(COMMENT_START);
-    let comment_end_finder = Finder::new(COMMENT_END);
+fn find_script_start(
+    source_text: &str,
+    pointer: usize,
+    script_start_finder: &Finder<'_>,
+    comment_start_finder: &FinderRev<'_>,
+    comment_end_finder: &Finder<'_>,
+) -> Option<usize> {
+    let mut new_pointer = pointer;
 
     loop {
         new_pointer +=
@@ -95,5 +98,5 @@ fn find_script_start(source_text: &str, pointer: &usize) -> Option<usize> {
         }
     }
 
-    Some(new_pointer - *pointer)
+    Some(new_pointer - pointer)
 }

crates/oxc_linter/src/loader/partial_loader/svelte.rs

@@ -1,10 +1,10 @@
-use memchr::memmem::Finder;
+use memchr::memmem::{Finder, FinderRev};
 
 use oxc_span::SourceType;
 
 use crate::loader::{JavaScriptSource, partial_loader::find_script_start};
 
-use super::{SCRIPT_END, find_script_closing_angle};
+use super::{COMMENT_END, COMMENT_START, SCRIPT_END, SCRIPT_START, find_script_closing_angle};
 
 pub struct SveltePartialLoader<'a> {
     source_text: &'a str,
@@ -35,10 +35,18 @@ impl<'a> SveltePartialLoader<'a> {
     }
 
     fn parse_script(&self, pointer: &mut usize) -> Option<JavaScriptSource<'a>> {
+        let script_start_finder = Finder::new(SCRIPT_START);
         let script_end_finder = Finder::new(SCRIPT_END);
-
+        let comment_start_finder = FinderRev::new(COMMENT_START);
+        let comment_end_finder: Finder<'_> = Finder::new(COMMENT_END);
         // find opening "<script"
-        *pointer += find_script_start(self.source_text, pointer)?;
+        *pointer += find_script_start(
+            self.source_text,
+            *pointer,
+            &script_start_finder,
+            &comment_start_finder,
+            &comment_end_finder,
+        )?;
 
         // find closing ">"
         let offset = find_script_closing_angle(self.source_text, *pointer)?;

crates/oxc_linter/src/loader/partial_loader/vue.rs

@@ -1,10 +1,13 @@
-use memchr::memmem::Finder;
+use memchr::memmem::{Finder, FinderRev};
 
 use oxc_span::SourceType;
 
-use crate::{frameworks::FrameworkOptions, loader::partial_loader::find_script_start};
+use crate::{
+    frameworks::FrameworkOptions,
+    loader::partial_loader::{SCRIPT_START, find_script_start},
+};
 
-use super::{JavaScriptSource, SCRIPT_END, find_script_closing_angle};
+use super::{COMMENT_END, COMMENT_START, JavaScriptSource, SCRIPT_END, find_script_closing_angle};
 
 pub struct VuePartialLoader<'a> {
     source_text: &'a str,
@@ -35,8 +38,17 @@ impl<'a> VuePartialLoader<'a> {
     }
 
     fn parse_script(&self, pointer: &mut usize) -> Option<JavaScriptSource<'a>> {
+        let script_start_finder = Finder::new(SCRIPT_START);
+        let comment_start_finder = FinderRev::new(COMMENT_START);
+        let comment_end_finder: Finder<'_> = Finder::new(COMMENT_END);
         // find opening "<script"
-        *pointer += find_script_start(self.source_text, pointer)?;
+        *pointer += find_script_start(
+            self.source_text,
+            *pointer,
+            &script_start_finder,
+            &comment_start_finder,
+            &comment_end_finder,
+        )?;
 
         // skip `<script-`
         if !self.source_text[*pointer..].starts_with([' ', '>']) {