From 65ed43286746858700e566a0ba4e1ae47d54c342 Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Wed, 8 Jan 2025 01:33:01 +0000 Subject: [PATCH] refactor(transformer/arrow-functions): reduce repeated code (#8323) Follow-on after #8024. Pure refactor. Make `self.visit_statement(stmt)` only get called in one place, rather than 2. --- .../src/common/arrow_function_converter.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/crates/oxc_transformer/src/common/arrow_function_converter.rs b/crates/oxc_transformer/src/common/arrow_function_converter.rs index 420265fd78f8bc..1f982b9dfb05f5 100644 --- a/crates/oxc_transformer/src/common/arrow_function_converter.rs +++ b/crates/oxc_transformer/src/common/arrow_function_converter.rs @@ -1141,12 +1141,8 @@ impl<'a> VisitMut<'a> for ConstructorBodyThisAfterSuperInserter<'a, '_> { let mut new_stmts = vec![]; for (index, stmt) in statements.iter_mut().enumerate() { - let Statement::ExpressionStatement(expr_stmt) = stmt else { - self.visit_statement(stmt); - continue; - }; - - if expr_stmt.expression.is_super_call_expression() { + if matches!(stmt, Statement::ExpressionStatement(expr_stmt) if expr_stmt.expression.is_super_call_expression()) + { let assignment = self.create_assignment_to_this_temp_var(); let new_stmt = self.ctx.ast.statement_expression(SPAN, assignment); new_stmts.push((index, new_stmt));